refactor(launch): 根据 LWJGL 版本判断是否使用 LWJGL Unsafe Agent#8464
Open
Big-Cake-jpg wants to merge 1 commit intoMeloong-Git:mainfrom
Open
refactor(launch): 根据 LWJGL 版本判断是否使用 LWJGL Unsafe Agent#8464Big-Cake-jpg wants to merge 1 commit intoMeloong-Git:mainfrom
Big-Cake-jpg wants to merge 1 commit intoMeloong-Git:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本 PR 将原本根据 Minecraft 与 Java 版本判断是否应用 LWJGL Unsafe Agent 的逻辑更改为了根据 LWJGL 版本判断,理论上这会减少出现问题时的影响范围、并且能够支持所有可能存在问题的 MC 实例(例如 26.1-snapshot-8 与其他启动器安装的 Cleanroom 实例)。
HMCL 与 PCL CE 均通过判断 LWJGL 版本决定是否使用 LUA,此次修改将逻辑与其对齐以防出现可能的意外行为。
相关代码来自 PCL CE,现将此修复重新贡献回上游。
PCL-Community/PCL-CE@44c2d30