Open
Conversation
wyc-26
suggested changes
Apr 5, 2026
Collaborator
wyc-26
left a comment
wyc-26
left a comment
There was a problem hiding this comment.
没提交 issue 直接写 pr 风险极高，因为根本不知道玩家群体的需求（
| Hint("请先选择一个版本！", HintType.Red) | ||
| Return | ||
| End If | ||
| If (PageType = CompType.Mod Or PageType = CompType.Shader) And Not McInstanceSelected.Modable Then '确认用户在下载 Mod 相关资源时选择了可使用 Mod 的版本 |
Collaborator
There was a problem hiding this comment.
原版其实也可以添加光影包
e.g. https://modrinth.com/resourcepack/re-shaded
| </Grid.ColumnDefinitions> | ||
| <local:MyButton x:Name="BtnSearchRun" Text="搜索" MinWidth="140" Padding="13,0" Margin="0,0,20,0" ColorType="Highlight" /> | ||
| <local:MyButton x:Name="BtnSearchReset" Text="重置条件" MinWidth="140" Padding="13,0" Margin="0,0,20,0" Grid.Column="1" /> | ||
| <local:MyButton x:Name="BtnSearchMatch" Text="适配当前版本" MinWidth="140" Padding="13,0" Margin="0,0,20,0" Grid.Column="2" /> |
Collaborator
There was a problem hiding this comment.
这里最好初始时就设置 Visibility="Collapsed"，而不是在 .vb 中进行判断
Comment on lines
+67
to
69
| <local:MyButton x:Name="BtnSearchMatch" Text="适配当前版本" MinWidth="140" Padding="13,0" Margin="0,0,20,0" Grid.Column="2" /> | ||
| <local:MyButton x:Name="BtnSearchInstallModPack" Text="安装已有整合包" MinWidth="140" Padding="13,0" Margin="0,0,20,0" Grid.Column="2" | ||
| ToolTip="在当前选择的 Minecraft 文件夹下安装整合包" ToolTipService.HorizontalOffset="-55" ToolTipService.VerticalOffset="5" /> |
Collaborator
There was a problem hiding this comment.
两个按钮共用一个 Column 感觉容易出事，虽然它们不会同时显示
Member
|
hmm #7844 会直接选择目标游戏版本，这就已经覆盖这个 PR 了……所以目前没有合并这个的需求 qwq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加了一个按钮，可以填充当前选中的版本的信息到文本框。
在整合包下载页面不显示。
在 Mod 和光影包下载页面需要选中一个可安装 Mod 的版本。