refactor: Rename _searches-suffixed streams#313
Conversation
for more information, see https://pre-commit.ci
ReubenFrankel
changed the title
_searches-suffixed streams_searches-suffixed streams
|
Could have sworn I'd seen |
We could get it added to the org config: https://github.com/MeltanoLabs/.github/blob/main/.github/semantic.yml |
|
@edgarrmondragon Do we generally call out breaking changes in the release notes, or is there a better pattern to follow that you have done before? e.g. deprecating streams/stream properties before removal |
I've been doing it based on vibes 🥴, i.e. on how much I think the tap/setting/stream/field is being used. If a stream is fundamentally broken such that no one could be seriously using it, I just make the breaking change unceremoniously. This PR feels to be along those lines. |
Sure, that makes sense 😅 I guess also we can be less formal about breaking changes given that we are pre-v1 currently. Appreciate the guidance. 🙏 |
|
FWIW, the stream was not broken prior to this change but did uncover and address the use of deprecated workflows endpoints:
I think that is grounds enough to make the change unceremoniously. |
|
2 participants
I guess these streams had a suffix of
_searchesto reflect the API endpoint they were referencing, but this makes it seems like they are pulling data around the search itself rather than entity data.Renaming caused a conflict in stream names for workflows - it appears we had two of these for whatever reason. I've consolidated these into one and updated the schema, but this is another breaking change.