fix: Sync custom field options for known option types only#317
Merged
ReubenFrankel merged 2 commits intoMeltanoLabs:mainfrom Mar 17, 2026
Merged
fix: Sync custom field options for known option types only#317ReubenFrankel merged 2 commits intoMeltanoLabs:mainfrom
ReubenFrankel merged 2 commits intoMeltanoLabs:mainfrom
Conversation
Contributor
|
In our case, we have types of supports_options = type_.startswith("option")Perhaps we would be better off matching against a set of known option types, starting with the above two: type_: str = schema.get("items") or schema["type"]
supports_options = type_ in {"option", "option-with-child"} |
Contributor
Author
|
@ReubenFrankel updated per your comments and added a check for known option types |
options)
ReubenFrankel
approved these changes
Mar 17, 2026
Contributor
|
Cheers @steven-luabase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into an error after this PR: #314
Not sure if it's just our Jira instance but we have some custom fields that return type
optionand others with typeoption2. Those withoption2do not work whensupports_options = true:singer_sdk.exceptions.FatalAPIError: 400 Client Error: Bad Request for path: /rest/api/3/field/customfield_10090/context/10212/option, content is {\"errorMessages\":[\"The custom field doesn't support options.\"]This PR makes an explicit check for if
type_ = option.