fix(config): handle non-object JSON documents - #2235
Open
fallenmi wants to merge 1 commit into
Open
Conversation
fallenmi
force-pushed
the
codex/fix-config-top-level-shape
branch
from
August 15, 2026 13:24
308a830 to
2d10c4e
Compare
fallenmi
marked this pull request as ready for review
August 15, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
config.jsonis a JSON object before storing it as MemPalace configuration..get()call.null, array, string, number, and boolean top-level documents.Closes #2234.
Why?
JSON permits non-object values at the top level.
MempalaceConfigpreviously assigned any successfuljson.load()result to_file_config, while all downstream properties assume a mapping. A file containingnull,[], a string, a number, or a boolean therefore raisedAttributeErroracross CLI, MCP, mining, and hook consumers.The fallback matches the class's existing fail-soft behavior for malformed JSON, Unicode decode errors, and unreadable files. It does not rewrite the user's file, emit output on the MCP stdio channel, or alter valid object configurations.
How to test
Local result after rebasing onto current
develop: 286 passed, 1 skipped. Ruff check, Ruff format, andgit diff --checkpass.Checklist