fix(graph): scope tunnel reads and deletes to config - #2264
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
list_tunnels,follow_tunnels, anddelete_tunneltunnels.json_configthrough all four tunnel handlersThe root cause was an incomplete config-propagation path:
create_tunnel(..., config=selected)already wrote to the selected sidecar, but its matching readers either ignored or could not accept that config. With ambient palace B active,follow_tunnels(..., config=A)therefore returned B's same-ID record; deletion could likewise mutate B while leaving A untouched.Calls that omit
configretain the existing default-palace behavior. This completes the tunnel read/delete side of the palace-isolation work merged in #2018.Closes #2263
How to test
.venv/bin/python -m pytest -q tests/test_palace_graph_tunnels.py tests/test_mcp_server.py— 425 passed.venv/bin/python -m pytest -q tests/test_palace_graph_tunnels.py tests/test_closets.py— 130 passed.venv/bin/python -m pytest -q tests/test_miner.py— 128 passed.venv/bin/pre-commit run --all-files— Ruff check and format passedChecklist