fix(graph): skip malformed tunnel records - #2269
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tunnels.jsonentry centrally in_load_tunnelskind, timestamps, drawer IDs, or dynamicsThe root cause was that
_load_tunnelsvalidated only the outer list. Consumers then called.getor indexed endpoint keys on arbitrary JSON elements, so onenull, string, phantom dict, or partial endpoint blocked every valid tunnel behind it and surfaced through MCP as an internal tool error.Read-only list/follow calls do not rewrite the sidecar. A later create/delete persists the filtered valid set through the existing atomic write path, matching the loader's established fail-soft recovery behavior. Unsupported non-list roots remain unsupported; changing destructive recovery for those files is intentionally outside this patch.
Closes #2266
How to test
.venv/bin/python -m pytest -q tests/test_palace_graph_tunnels.py— 59 passed.venv/bin/python -m pytest -q tests/test_closets.py tests/test_miner.py— 202 passed.venv/bin/python -m pytest -q tests/test_mcp_server.py— 368 passed.venv/bin/pre-commit run --all-files— Ruff check and format passedChecklist