[Chore] Debug toggles, Javadoc coverage, and code quality cleanup#283
Merged
Conversation
- Added 6 new verbose debug channels: Input, Skill, Ability, Grab, Attack, Throwing (Config.Debug flags + Debug.java methods + TogglesMenu.java toggles + config.yaml sync) - Synced config.yaml debug section with all verbose flags that existed in Config.java - Expanded TogglesMenu layout from 15 to 22 items to accommodate new toggles - Fixed if(true ||) gate in MainMenu.java — dev menu now correctly requires op - Fixed THROW_TRAIl constant name typo → THROW_TRAIL in Prefab.java and all consumers - Removed dead commented-out code in MovementListener, QueueManager, CaptureTheFlag1v1 - Added class-level Javadoc to: SwordPluginLoader, ArenaManager, QueueManager, Gamemode, CaptureTheFlag1v1, SystemListener, EntityPacketListener, MovementListener, Dash, Dummy, Menu, MainMenu, StateMachine, State, SoundUtil, SwordTimeUnit, SwordSoundType, SkillRegistry, SkillId, SkillIds, SkillType, SkillSlot, SkillSlotActionFactory, SkillSlotRules, PlayerSkillContainer, ActiveSkill, and Prefab inner classes (Instructions, Attacks, Sounds, PotionEffects, Text) - Added method-level Javadoc to ~60 previously undocumented public methods - Fixed Checkstyle: private constructors on SoundUtil/SwordTimeUnit utility classes, empty brace whitespace in StateMachine and Transition, long lines in Prefab.PotionEffects - Javadoc coverage: 55.3% → 58.3% (890 remaining, down from 954)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive cleanup and code quality improvements: new debug channels, expanded Javadoc coverage (55.3% → 58.3%), fixed logic gate in dev menu, corrected THROW_TRAIL typo, removed dead code, and resolved Checkstyle violations.
Related Issue
Closes #281
Checklist