Perf: skip status display rebuild when values unchanged#316
Closed
Mere-Solace wants to merge 1 commit into
Closed
Conversation
Cache prevDisplayShards and prevDisplayToughness on SwordEntity; return early from updateStatusDisplayText() when neither value has changed, eliminating ~700 Component allocations per second at 35 entities.
Mere-Solace
added
priority: medium
Mere-Solace
force-pushed
the
perf/status-display-cache-300
branch
from
5acb02f to
7c9430c
Compare
Owner
Author
|
Changes merged directly into dev via cherry-pick. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache previous display shards and toughness values in
SwordEntityto skip Component/String allocations when values haven't changed.Details
prevDisplayShards(int, init -1) andprevDisplayToughness(float, init -1f) cache fieldsupdateStatusDisplayText()now reads current values, compares against cache, and returns early if unchangedCloses #300