fillContours2D: add tilted-plane regression test#6310
Merged
Conversation
Characterize fillContours2D filling a hole on a plane tilted off all axes (the existing test only covers an axis-aligned z=0 cut). Pins the stable invariants: the hole closes watertight, boundary vertices are reused in place (no drift/duplication), and the patch lies in the cut plane oriented consistently. Guards the upcoming mesh-space rewrite of fillContours2D against silent behavior changes. Test-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test characterizing
fillContours2Don a hole in a plane tilted off all axes — the existing test only covers an axis-aligned z=0 cut.It pins the stable, observable invariants of the fill:
This guards the upcoming rewrite of
fillContours2Dto triangulate in the mesh's own 3D space — replacing the current project → triangulate → pin-vertices round-trip (part of the PlanarTriangulation input-space refactor, following #6306 / #6309) — so that change can't silently alter the result. Triangle quality is intentionally not pinned (the current fill emits slivers, and the exact triangulation isn't a stable invariant).Test-only; no production code changed. Verified passing against current
fillContours2D.🤖 Generated with Claude Code