add umdp3 fixer action - #21
Conversation
| - name: Checkout Branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: cloned_branch | ||
| token: ${{ secrets.gh_action_token }} |
There was a problem hiding this comment.
You probably want to checkout the PR branch here. The current implementation will checkout the default base branch which I think is not desirable
There was a problem hiding this comment.
No I don't think it does as this is being called on pull_request not pull_request_target
Yaswant Pradhan (yaswant)
left a comment
Yaswant Pradhan (yaswant)
left a comment
There was a problem hiding this comment.
Minor comments
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Pierre Siddall (Pierre-siddall)
left a comment
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
The workflow looks good to go to me, just one tiny suggestion when it comes to wording the README to differentiate between default inputs and inputs which override the defaults.
Co-authored-by: Pierre Siddall <43399998+Pierre-siddall@users.noreply.github.com>
Pierre Siddall (Pierre-siddall)
left a comment
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
Thanks James this looks good to head onto trunk now for me. Hopefully the fix for the failing yaml will be added to trunk soon.
2a0aa74
into
MetOffice:main
3 participants
Add a reusable action to run the UMDP3 fixer in CI - useful for UM, Jules, UKCA
Linked with MetOffice/SimSys_Scripts#129
This has been tested on UKCA code, both passing and failing as expected.