Validate - #25
Conversation
…Check step continues on error
…sary cache minimization step
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
A small query.
And do you want to fix the failing yamllint as part of this PR?
|
|
||
| validate: | ||
| name: QC | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I notice that you always use ubuntu-latest rather than ubuntu-X.Y. Is there a reason for this? I suspect our current workflows are unlikely to break between ubuntu versions, but I would instinctively prefer to not have that change under us
There was a problem hiding this comment.
Not always. For a workflow requiring code compilation I stick to a fixed version. For simple tools, prefer floating version: to be honest ubuntu-latest is pretty solid for most tasks (like this one). But I agree with you and probably change that to 24.04.
No. That workflow will get purged once #20 is in. |
c26c037
into
MetOffice:main
2 participants
At the moment there is no checks for contributed workflows. This PR adds an additional workflow to validate the changes in a PR.