Skip to content

Fortran linting workflow - #28

Merged
James Bruten (james-bruten-mo) merged 23 commits into
MetOffice:mainfrom
Pierre-siddall:fortitude-linting
Nov 17, 2025
Merged

Fortran linting workflow #28
James Bruten (james-bruten-mo) merged 23 commits into
MetOffice:mainfrom
Pierre-siddall:fortitude-linting

Conversation

@Pierre-siddall

@Pierre-siddall Pierre Siddall (Pierre-siddall) commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

This PR implements an optimisedl fortran linting workflow which makes use of fortitude and closes #7.

SciTech Reviewer: Yaswant Pradhan (@yaswant)
Code Reviewer: James Bruten (@james-bruten-mo)

@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as ready for review November 14, 2025 11:26
Comment thread fortran-lint/README.md Outdated
Comment thread fortran-lint/README.md
Comment thread fortran-lint/README.md
Comment thread fortran-lint/README.md
Comment thread fortran-lint/README.md Outdated
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as ready for review November 14, 2025 14:13
@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as draft November 14, 2025 14:17
@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as ready for review November 14, 2025 14:54
Comment thread .github/workflows/fortran-lint.yaml Outdated
Comment thread .github/workflows/fortran-lint.yaml Outdated
Comment thread .github/workflows/fortran-lint.yaml Outdated
@yaswant

Copy link
Copy Markdown
Collaborator

Also, by default, Fortitude will only check files with extensions: "f90", "F90", "f95", "F95", "f03", "F03", "f08", "F08", "f18", "F18", "f23", "F23". We need to extend the list to include "x90", "X90" (primarily for LFRic).

@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as draft November 17, 2025 08:15
@Pierre-siddall

This comment was marked as outdated.

@yaswant Yaswant Pradhan (yaswant) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting suggestion

Comment thread .github/workflows/fortran-lint.yaml Outdated
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@Pierre-siddall
Pierre Siddall (Pierre-siddall) marked this pull request as ready for review November 17, 2025 15:25

@yaswant Yaswant Pradhan (yaswant) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit. Approved.

Comment thread .github/workflows/fortran-lint.yaml Outdated
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@james-bruten-mo
James Bruten (james-bruten-mo) merged commit bde7a37 into MetOffice:main Nov 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Fortitude linting action

3 participants