Optimise fortran linting workflow using uv - #40
Merged
James Bruten (james-bruten-mo) merged 19 commits intoDec 9, 2025
Merged
Conversation
Contributor
Author
|
Tested using no fortran code to see if the uv cache minimization step ran then added some fortran code and tested using additional rules to a |
Pierre Siddall (Pierre-siddall)
requested review from
James Bruten (james-bruten-mo) and
Yaswant Pradhan (yaswant)
November 21, 2025 14:18
Pierre Siddall (Pierre-siddall)
marked this pull request as ready for review
November 21, 2025 14:19
Yaswant Pradhan (yaswant)
left a comment
Yaswant Pradhan (yaswant)
left a comment
Collaborator
There was a problem hiding this comment.
Pierre Siddall (@Pierre-siddall) there are some fundamental problems in the implementation - I feel that you are trying to over-engineer. See my suggestions and comments.
Pierre Siddall (Pierre-siddall)
marked this pull request as draft
November 27, 2025 08:40
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Pierre Siddall (Pierre-siddall)
added
enhancement
and removed
bug
Pierre Siddall (Pierre-siddall)
marked this pull request as ready for review
November 28, 2025 13:34
Pierre Siddall (Pierre-siddall)
requested a review
from Yaswant Pradhan (yaswant)
November 28, 2025 13:34
Yaswant Pradhan (yaswant)
left a comment
Yaswant Pradhan (yaswant)
left a comment
Collaborator
There was a problem hiding this comment.
Couple of minor naming suggestions so that the items dont appears repeatedly on PR Checks section.
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Pierre Siddall (Pierre-siddall)
requested a review
from Yaswant Pradhan (yaswant)
November 28, 2025 15:50
Yaswant Pradhan (yaswant)
previously approved these changes
Nov 28, 2025
Yaswant Pradhan (yaswant)
previously approved these changes
Dec 2, 2025
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
One suggestion for some other lfric file extensions
Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>
James Bruten (james-bruten-mo)
approved these changes
Dec 9, 2025
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Pierre, looks good
James Bruten (james-bruten-mo)
merged commit Dec 9, 2025
39a423c
into
MetOffice:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30