Skip to content

check for multiple approves #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yaswant Pradhan (yaswant) merged 2 commits into from
Dec 1, 2025
Merged

check for multiple approves #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6aa76d
check for multiple approves
james-bruten-mo Dec 1, 2025
99eaa8b
cr comments
james-bruten-mo Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/check-cr-approved.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,18 @@ jobs:
echo "Expected Code Reviewer: $CODE_REVIEWER"

# -- 2. Check the review status
CR_APPROVED=$(gh pr view -R "$REPO" "$PR_NUMBER" --json "reviews" |
jq -r --arg cr "$CODE_REVIEWER" ' .reviews[] |
select((.author.login == $cr) and .state == "APPROVED") |
.state')
reviews=$(gh pr view -R "$REPO" "$PR_NUMBER" --json "reviews" | jq -r --arg cr "$CODE_REVIEWER" '
[ .reviews[] | select(.author.login == $cr) ]')

if [[ "$CR_APPROVED" == "APPROVED" ]]; then
# Check if any review is APPROVED
approved=$(echo "$reviews" | jq -r '[ .[] | select(.state == "APPROVED") ] | length')

if [[ "$approved" -gt 0 ]]; then
echo "✅ Success: The listed Code Reviewer ($CODE_REVIEWER) has approved this PR."
else
# Exit with failure if the specific reviewer has not yet approved
echo "::error::The listed Code Reviewer ($CODE_REVIEWER) has not yet approved this PR."
echo "Current reviews for this user:"
gh pr view -R "$REPO" "$PR_NUMBER" --json "reviews" | jq -r --arg cr "$CODE_REVIEWER" '
.reviews[] | select(.author.login == $cr) | "- \(.state)"'

echo "$reviews" | jq -r '.[] | "- \(.state)"'
echo "::notice::This action may be bypassed by a reviewer with sufficient permissions if appropriate."
exit 1
fi