Update cla url - #43
Merged
Yaswant Pradhan (yaswant) merged 7 commits intoDec 9, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
commented
Dec 8, 2025
James Bruten (james-bruten-mo)
commented
Collaborator
- Updates the URL in the cla-check action to point at new momentum repo
- Adds a echo to check-cr-approved to note PR number and Repo
James Bruten (james-bruten-mo)
requested a review
from Yaswant Pradhan (yaswant)
December 8, 2025 11:57
Collaborator
Author
|
Yaswant Pradhan (@yaswant) I've copied over the changes to the workflow that grep for the pipe symbol and change the filename to CONTRIBUTORS.md into this PR. I suggest we get this one on and then get the check for removal working in your PR |
| if [ -f "CONTRIBUTORS" ]; then | ||
| if grep -q "^$AUTHOR" CONTRIBUTORS; then | ||
| if [ -f "CONTRIBUTORS.md" ]; then | ||
| if grep -qE "\|\s*$AUTHOR" CONTRIBUTORS.md; then |
Collaborator
There was a problem hiding this comment.
Did you not want to check for the extra spaces after $AUTHOR?
Collaborator
Author
There was a problem hiding this comment.
Done
Yaswant Pradhan (yaswant)
approved these changes
Dec 9, 2025
Yaswant Pradhan (yaswant)
left a comment
Yaswant Pradhan (yaswant)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.