remove labelling when cla already signed on base - #46
Conversation
|
Yaswant Pradhan (@yaswant) and Andrew Coughtrie (@andrewcoughtrie) I've changed this so that I think it checks out the merged branch and then compares it to the head of the base branch. It's targeting main right now to make the diff easier to see, but I suspect we should merge into develop and test from there first. If you're happy to do that then please go ahead and change the target and merge |
|
I am not sure that will do anything different than before. But can you target develop instead of main for testing first. |
|
Yaswant Pradhan (@yaswant) yeah that was my intention. I think removing the |
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
Lets test this.
61639ac
into
MetOffice:develop
At the moment we get a
cla-signedlabel, even when the developer has already signed the cla on base. I'd strongly argue we should only get acla-signedlabel in the PRs where the developer is signing the cla. Otherwise it'll just become meaningless noise