Skip to content

remove labelling when cla already signed on base - #46

Merged
Andrew Coughtrie (andrewcoughtrie) merged 6 commits into
MetOffice:developfrom
james-bruten-mo:remove_label
Dec 17, 2025
Merged

remove labelling when cla already signed on base#46
Andrew Coughtrie (andrewcoughtrie) merged 6 commits into
MetOffice:developfrom
james-bruten-mo:remove_label

Conversation

@james-bruten-mo

Copy link
Copy Markdown
Collaborator

At the moment we get a cla-signed label, even when the developer has already signed the cla on base. I'd strongly argue we should only get a cla-signed label in the PRs where the developer is signing the cla. Otherwise it'll just become meaningless noise

@james-bruten-mo
James Bruten (james-bruten-mo) changed the base branch from main to develop December 16, 2025 16:34
@james-bruten-mo
James Bruten (james-bruten-mo) changed the base branch from develop to main December 16, 2025 16:41
@james-bruten-mo
James Bruten (james-bruten-mo) marked this pull request as draft December 16, 2025 16:42
@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

Yaswant Pradhan (@yaswant) and Andrew Coughtrie (@andrewcoughtrie) I've changed this so that I think it checks out the merged branch and then compares it to the head of the base branch. It's targeting main right now to make the diff easier to see, but I suspect we should merge into develop and test from there first. If you're happy to do that then please go ahead and change the target and merge

@yaswant

Copy link
Copy Markdown
Collaborator

I am not sure that will do anything different than before. But can you target develop instead of main for testing first.

@yaswant
Yaswant Pradhan (yaswant) changed the base branch from main to develop December 16, 2025 17:03
@james-bruten-mo
James Bruten (james-bruten-mo) marked this pull request as ready for review December 16, 2025 17:06
@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

Yaswant Pradhan (@yaswant) yeah that was my intention. I think removing the ref from the checkout action will mean it gets the PR branch merged into the base branch. And then checking that there is no diff of CONTRIBUTORS between that and the base will give us what we want. I might be wrong though!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets test this.

@andrewcoughtrie
Andrew Coughtrie (andrewcoughtrie) merged commit 61639ac into MetOffice:develop Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants