Skip to content

Ignore unable assign - #57

Merged
Yaswant Pradhan (yaswant) merged 7 commits into
MetOffice:mainfrom
james-bruten-mo:ignore_unable_assign
Jan 22, 2026
Merged

Ignore unable assign#57
Yaswant Pradhan (yaswant) merged 7 commits into
MetOffice:mainfrom
james-bruten-mo:ignore_unable_assign

Conversation

@james-bruten-mo

Copy link
Copy Markdown
Collaborator

Adds continue-on-error: true to some of the steps in the project tracker workflow, to avoid failures where a user can't be assigned/review

@yaswant Yaswant Pradhan (yaswant) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions for your consideration

Comment thread .github/workflows/track-review-project.yaml Outdated
Comment thread .github/workflows/track-review-project.yaml Outdated
Comment thread .github/workflows/track-review-project.yaml
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

Thanks, suggestions applied and indenting updated.
Does the parsing of a step get stopped if the if statement doesn't match. I'd sort of assumed that it would load the settings regardless of the order, but just not execute if the if isn't satisfied?

@yaswant

Yaswant Pradhan (yaswant) commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks, suggestions applied and indenting updated. Does the parsing of a step get stopped if the if statement doesn't match. I'd sort of assumed that it would load the settings regardless of the order, but just not execute if the if isn't satisfied?

Yes, that is correct regardless of where you put the continue-on-error: true. But our goal is to move on to the next step regardless of the state of the current step, right?

@yaswant
Yaswant Pradhan (yaswant) merged commit 1d7bc6d into MetOffice:main Jan 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants