Add logic to check CR in progress for trivial review - #59
Merged
James Bruten (james-bruten-mo) merged 3 commits intoJan 23, 2026
Conversation
Jenny Hickson (jennyhickson)
requested a review
from James Bruten (james-bruten-mo)
January 23, 2026 09:57
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
A missing $ but otherwise looks good
Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com>
James Bruten (james-bruten-mo)
approved these changes
Jan 23, 2026
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks
James Bruten (james-bruten-mo)
merged commit Jan 23, 2026
6f12c3c
into
MetOffice:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, once the code reviewer requests changes or approves a PR the logic to recognise a trivial PR breaks. Add checks for these states to the workflow.