Allow substepping of just tracers - #733
Open
Thomas Bendall (tommbendall) wants to merge 5 commits into
Open
Conversation
Update stable for vn3.1
Merge vn3.2 stable
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: James Kent (@jameskent-metoffice)
Code Reviewer: Ricky Wong (@mo-rickywong)
Some groups of tracers are transported separately from the standard dynamics prognostics, in the following situations:
The transport of these tracers involves resetting and recalculating various quantities that are shared across a transport step. However the process of resetting this hasn't previously involved all of our standard stability mechanisms, and in particular substepping has been missing.
This PR implements that substepping, which has allowed some failures in high resolution, large timestep TR-BDF2 simulations to be avoided.
Although this PR could hypothetically change KGOs for tests with the above situations, in practice there are no tests in the suite that trigger these situations.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - tracer_substep/run2
Suite Information
Task Information
✅ succeeded tasks - 1210
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review