Add support for the test suite on monsoon 3 - #248
Merged
Conversation
Update the rose-stem configuration files to simplify the process of running the test suite on the monsoon 3 partition of EXD.
Sam Clarke-Green (t00sa)
requested review from
James Bruten (james-bruten-mo) and
Ricky Wong (mo-rickywong)
as code owners
January 27, 2026 14:21
Sam Clarke-Green (t00sa)
marked this pull request as draft
January 27, 2026 14:21
James Bruten (james-bruten-mo)
marked this pull request as ready for review
January 28, 2026 11:07
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
Just removing the duplicated directives and the commented out lines
|
|
||
| {# Platform Generic Groups #} | ||
| {% if site_vars.launch_platform == "azspice" %} | ||
| {# {% if site_vars.launch_platform == "azspice" %} #} |
Collaborator
There was a problem hiding this comment.
Probably best to just remove this and the endif. Maybe the lines below need unindenting too?
| HYPERTHREADS = 1 | ||
| CORES_PER_NODE = 128 | ||
| NUMA_REGIONS_PER_NODE = 2 | ||
| [[[directives]]] |
Collaborator
There was a problem hiding this comment.
Get Rid
Sam Clarke-Green (t00sa)
requested a review
from James Bruten (james-bruten-mo)
February 3, 2026 08:41
James Bruten (james-bruten-mo)
approved these changes
Feb 3, 2026
James Bruten (james-bruten-mo)
left a comment
Collaborator
There was a problem hiding this comment.
Also good, cheers
R Sharp (r-sharp)
approved these changes
Feb 4, 2026
R Sharp (r-sharp)
left a comment
Contributor
There was a problem hiding this comment.
Everything appears in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the rose-stem configuration files to simplify the process of running the test suite on the monsoon 3 partition of EXD.
PR Summary
Sci/Tech Reviewer: James Bruten (@james-bruten-mo)
Code Reviewer: R Sharp (@r-sharp)
Similar to trac ticket #779 and MetOffice/lfric_apps#166, this adds support for the test suites on monsoon 3 using github PATs to access the repositories.
Code Quality Checklist
Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review