Skip to content

Mpifort makefile - #251

Merged
Ed Hone (EdHone) merged 10 commits into
MetOffice:mainfrom
andrewcoughtrie:mpifort_makefile
Jan 28, 2026
Merged

Mpifort makefile#251
Ed Hone (EdHone) merged 10 commits into
MetOffice:mainfrom
andrewcoughtrie:mpifort_makefile

Conversation

@andrewcoughtrie

@andrewcoughtrie Andrew Coughtrie (andrewcoughtrie) commented Jan 27, 2026 •
edited by EdHone
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Creating a duplicate of mpif90.mk for the more modern mpifort.mk, this is only a short term solution to allow JEDI to use the more modern mpifort, this should also be considered when creating the fab build system.

Sci/Tech Reviewer: Mike Hobson (@mike-hobson)
Code Reviewer: Ed Hone (@EdHone)

closes #245

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

Test Suite Results - lfric_core - PR251/run1

Suite Information

Item Value
Suite Name PR251/run1
Suite User andrew.coughtrie
Workflow Start 2026-01-28T11:47:03
Groups Run developer
Dependency Reference Main Like
lfric_core andrewcoughtrie/lfric_core@mpifort_makefile False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 372

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@andrewcoughtrie Andrew Coughtrie (andrewcoughtrie) linked an issue Jan 27, 2026 that may be closed by this pull request
Support mpifort in addtion to and/or to replace mpif90 #245
Closed
@andrewcoughtrie

Andrew Coughtrie (andrewcoughtrie) commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator Author

Matt Shin (@matthewrmshin) can you test that this branch does what you want it to? I've tested it locally and it seems to work as expected.

@matthewrmshin

Matt Shin (matthewrmshin) commented Jan 27, 2026

Copy link
Copy Markdown

Andrew Coughtrie (@andrewcoughtrie) Thanks.

David Davies (@DJDavies2) Pleasse have a look at this branch and see if it solves the mpifort problem raised at MetOffice/mo-bundle#859. I'll do some separate tests in my environment as well.

matthewrmshin
Matt Shin (matthewrmshin) reviewed Jan 27, 2026
View reviewed changes
Comment thread components/lfric-xios/source/lfric_xios_setup_mod.x90 Outdated
type(field_type), intent(in) :: panel_id
type(field_type), optional, intent(in) :: alt_coords(:,:)
type(field_type), optional, intent(in) :: alt_panel_ids(:)
type(field_type), optional, intent(in) :: panel_ids(:)

@matthewrmshin Matt Shin (matthewrmshin) Jan 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a failure due to this line. Compiler says this is not a dummy variable.

@andrewcoughtrie Andrew Coughtrie (andrewcoughtrie) Jan 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry my fault I seem to have managed to pull in other stuff rather than branching from where I should.

@andrewcoughtrie Andrew Coughtrie (andrewcoughtrie) Jan 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the erroneous commits so there is only the change I actually intended.

@matthewrmshin Matt Shin (matthewrmshin) Jan 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll re-test now.

@matthewrmshin Matt Shin (matthewrmshin) Jan 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now.

@andrewcoughtrie
Andrew Coughtrie (andrewcoughtrie) marked this pull request as ready for review January 28, 2026 12:01
mike-hobson
Mike Hobson (mike-hobson) requested changes Jan 28, 2026
View reviewed changes
Comment thread infrastructure/build/fortran/mpifort.mk Outdated
@andrewcoughtrie @mike-hobson
Update infrastructure/build/fortran/mpifort.mk
1c555ea 
Co-authored-by: Mike Hobson <26921912+mike-hobson@users.noreply.github.com>
EdHone
Ed Hone (EdHone) approved these changes Jan 28, 2026
View reviewed changes

@EdHone Ed Hone (EdHone) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is fine - worth documenting for future build system development with fab

@EdHone
Ed Hone (EdHone) self-requested a review January 28, 2026 15:06
@EdHone
Ed Hone (EdHone) merged commit a6bb816 into MetOffice:main Jan 28, 2026
7 checks passed
@hiker Joerg Henrichs (hiker) mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mike-hobson Mike Hobson (mike-hobson) mike-hobson approved these changes
@EdHone Ed Hone (EdHone) EdHone approved these changes
@MatthewHambley Matthew Hambley (MatthewHambley) Awaiting requested review from MatthewHambley MatthewHambley is a code owner
@stevemullerworth Steve Mullerworth (stevemullerworth) Awaiting requested review from stevemullerworth
+1 more reviewer
@matthewrmshin Matt Shin (matthewrmshin) matthewrmshin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@andrewcoughtrie Andrew Coughtrie (andrewcoughtrie)

Labels

None yet

Projects

None yet

Milestone

Spring 2026

Development

Successfully merging this pull request may close these issues.

Support mpifort in addtion to and/or to replace mpif90

6 participants

@andrewcoughtrie @matthewrmshin @mike-hobson @EdHone @jennyhickson @mo-ssd-bot