Skip to content

Prepartitioning with threading race condition fix #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benjamin Went (MetBenjaminWent) merged 7 commits into from
Aug 24, 2026
Merged

Prepartitioning with threading race condition fix #450

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a20c46
Using nf90_netcdf6
mattatmet Jul 22, 2026
e6de9b1
Separating the declaration nullification of linked list pointer
mattatmet Aug 18, 2026
558cf15
Merge branch 'MetOffice:main' into offline_partition
mattatmet Aug 18, 2026
6465d91
removing nf90_netcdf4 change
mattatmet Aug 18, 2026
295519a
style change suggestion
mattatmet Aug 19, 2026
82af214
Merge branch 'main' into offline_partition
mattatmet Aug 19, 2026
b9b46c1
Merge branch 'main' into offline_partition
MetBenjaminWent Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion infrastructure/source/mesh/global_mesh_map_collection_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,9 @@ function get_global_mesh_map( self, &
logical(l_def) :: global_mesh_map_exists

! Pointer to linked list - used for looping through the list
type(linked_list_item_type),pointer :: loop => null()
type(linked_list_item_type),pointer :: loop

nullify(loop)

@MetBenjaminWent Benjamin Went (MetBenjaminWent) Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this instead be, (for consistency)? : loop => null()

@MetBenjaminWent Benjamin Went (MetBenjaminWent) Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for CO too Ricky Wong (@mo-rickywong)

@mattatmet Matthew Walker (mattatmet) Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Benjamin Went (@MetBenjaminWent), agreed, have pushed this change now.

global_mesh_map => null()

global_mesh_map_id = generate_global_mesh_map_id( source_global_mesh_id, &
Expand Down
Loading