Skip to content

chore: migrate NPM publishing to trusted publishing (OIDC) via action-npm-publish@v6 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenfix wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

chore: migrate NPM publishing to trusted publishing (OIDC) via action-npm-publish@v6 #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/publish-release.yml
View file
Open in desktop

@Mrtenz Mrtenz Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main.yml also needs to be updated to have id-token: write permission when calling this workflow.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_call:
secrets:
NPM_TOKEN:
required: true
required: false
SLACK_WEBHOOK_URL:
required: true
PUBLISH_DOCS_TOKEN:
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
with:
name: publish-release-artifacts-${{ github.sha }}
- name: Dry run publish to NPM
uses: MetaMask/action-npm-publish@v5
uses: MetaMask/action-npm-publish@v6
with:
slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_URL }}
subteam: S042S7RE4AE # @metamask-npm-publishers
Expand All @@ -62,6 +62,9 @@ jobs:
environment: npm-publish
runs-on: ubuntu-latest
needs: publish-npm-dry-run
permissions:
contents: read
id-token: write
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
Expand All @@ -73,7 +76,7 @@ jobs:
with:
name: publish-release-artifacts-${{ github.sha }}
- name: Publish to NPM
uses: MetaMask/action-npm-publish@v5
uses: MetaMask/action-npm-publish@v6
with:
npm-token: ${{ secrets.NPM_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"vitest": "^3.1.2",
"yargs": "^17.7.2"
},
"packageManager": "yarn@4.9.2",
"packageManager": "yarn@4.16.0",
"engines": {
"node": ">=20.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Manual changes might be lost - proceed with caution!

__metadata:
version: 8
version: 10
cacheKey: 10

"@0no-co/graphql.web@npm:^1.0.13, @0no-co/graphql.web@npm:^1.0.8":
Expand Down
Loading