Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.tsx
Outdated
Show resolved
Hide resolved
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
…gn-system into dsrn/headersearch
…o dsrn/headersearch
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
…o dsrn/headersearch
Contributor
📖 Storybook Preview |
packages/design-system-shared/src/types/HeaderSearch/HeaderSearch.types.ts
Outdated
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.tsx
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.stories.tsx
Show resolved
Hide resolved
packages/design-system-react-native/src/components/HeaderSearch/README.md
Outdated
Show resolved
Hide resolved
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
Contributor
There was a problem hiding this comment.
LGTM! Made a small update fb8c61f to the stories to align with the readme
packages/design-system-react-native/src/components/HeaderSearch/HeaderSearch.stories.tsx
Outdated
Show resolved
Hide resolved
georgewrmarshall
previously approved these changes
Apr 7, 2026
Contributor
📖 Storybook Preview |
amandaye0h
previously approved these changes
Apr 7, 2026
brianacnguyen
dismissed stale reviews from amandaye0h and georgewrmarshall
via
e54a227
Contributor
📖 Storybook Preview |
…o dsrn/headersearch
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds HeaderSearch to
@metamask/design-system-react-native: a header row that pairs TextFieldSearch with navigation actions, so product teams get a consistent search header instead of reimplementing layout and behavior.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-330
Manual testing steps
yarn storybook:iosoryarn storybook:android).yarn workspace @metamask/design-system-react-native run test -- HeaderSearchoryarn jestwith the package’s test pattern if you want to double-check tests locally.Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-04-01.at.15.27.53.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: this PR is additive (new component, types, stories, and tests) with no changes to existing component behavior; main risk is minor API/export integration issues for consumers.
Overview
Introduces
HeaderSearchto@metamask/design-system-react-native, providing a single header row that pairsTextFieldSearchwith either a back icon (Screenvariant) or a tertiary Cancel action (Inlinevariant), with variant-driven (discriminated) props.Exports
HeaderSearchandHeaderSearchVariantvia the package component index and adds corresponding sharedHeaderSearch*types to@metamask/design-system-shared. Includes Storybook stories, a README, and a comprehensive test suite covering prop forwarding, handler precedence (preventing override ofonPress), andtwClassNamemerging.Reviewed by Cursor Bugbot for commit 19d089a. Bugbot is set up for automated code reviews on this repo. Configure here.