Skip to content

design-tokens: Update dark theme background.default to pure black (#000000) #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
georgewrmarshall wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

design-tokens: Update dark theme background.default to pure black (#000000) #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbc33d1
design-tokens(dark): set background.default to pure black (#000000) a…
cursoragent Apr 6, 2026
d011282
design-tokens: reference brand black token for dark background defaul…
cursoragent Apr 6, 2026
52ee036
docs(design-tokens): revert CHANGELOG modification per review (not a …
cursoragent Apr 6, 2026
8439c9e
design-tokens(dark): keep black via direct values for CSS/Figma to sa…
cursoragent Apr 6, 2026
beee588
Handle {black} token in theme CSS tests and apply lint fix
georgewrmarshall Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/design-system-react-native/src/components/HeaderRoot/HeaderRoot.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-console */
import React from 'react';

import { Box, BoxAlignItems, BoxFlexDirection } from '../Box';
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/src/css/dark-theme-colors.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/* Background default should be the darkest shade, 0 elevation.
Section is +1 elevation, subsection is +2 elevation.
Alternative should be deprecated. */
--color-background-default: var(--brand-colors-grey-grey900);
--color-background-default: #000000;
--color-background-section: var(--brand-colors-grey-grey800);
--color-background-subsection: var(--brand-colors-grey-grey700);
--color-background-alternative: var(--brand-colors-grey-grey1000);
Expand Down
2 changes: 2 additions & 0 deletions packages/design-tokens/src/css/darkTheme.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ describe('Dark Theme Colors CSS', () => {
const shade: string | undefined = parts[1];
if (color && shade) {
cssValue = `var(--brand-colors-${color}-${color}${shade})`;
} else if (color && !shade) {
cssValue = `var(--brand-colors-${color})`;
} else {
throw new Error(`Invalid color or shade: ${value as string}`);
}
Expand Down
2 changes: 2 additions & 0 deletions packages/design-tokens/src/css/lightTheme.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ describe('Light Theme Colors CSS', () => {
const shade: string | undefined = parts[1];
if (color && shade) {
cssValue = `var(--brand-colors-${color}-${color}${shade})`;
} else if (color && !shade) {
cssValue = `var(--brand-colors-${color})`;
} else {
throw new Error(`Invalid color or shade: ${value as string}`);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/src/figma/darkTheme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"background": {
"default": {
"value": "{grey.900}",
"value": "#000000",
"type": "color",
"parent": "Theme Colors/Dark mode",
"description": "For default neutral surface."
Expand Down
6 changes: 3 additions & 3 deletions packages/design-tokens/src/js/themes/darkTheme/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ import type { ThemeColors } from '../types';

export const colors: ThemeColors = {
background: {
/** For default neutral surface (#222325) */
default: brandColor.grey900,
/** For default neutral surface (pure black #000000) */
default: brandColor.black,
/** For sunken neutral surface below background/default. (#121314) */
alternative: brandColor.grey1000,
/** For section bg usually over background/default (#31333A) */
section: brandColor.grey800,
/** For subsection bg usually over background/section (#222325) */
/** For subsection bg usually over background/section (#252628) */
subsection: brandColor.grey700,
/** For muted neutral surface (#ffffff0a) */
muted: '#ffffff0a',
Expand Down
Loading