release(runway): cherry-pick fix: reload after failed transaction cp-13.26.0#41523
Merged
chloeYue merged 1 commit intorelease/13.26.0from Apr 8, 2026
Merged
Conversation
…13.26.0 (#41519) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Remove the `sidePanel.setOptions` call on failed transactions that caused the sidepanel to reload when already open. This mitigates the issue, while considering alternative solutions for an "open-and-navigate-to-tab" ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: #41473 ## **Manual testing steps** 1. Submit a transaction that will fail while the sidepanel is open ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Small behavioral change limited to MV3 UI configuration after failed/dropped transactions; risk is low and mainly involves ensuring the action popup still points to the Activity tab without unintended side effects. > > **Overview** > Prevents the side panel from reloading on failed/dropped transactions by **removing the MV3 `browser.sidePanel.setOptions` updates** that previously changed the side panel path to `?tab=activity` (and back when cleared). > > Failed-transaction handling now only updates the extension action popup (`browser.action.setPopup`) while keeping the badge count/clearing behavior unchanged. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 47de11d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Contributor
Builds ready [adf6f0f]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
sidePanel.setOptionscall on failed transactions thatcaused the sidepanel to reload when already open.
This mitigates the issue, while considering alternative solutions for an
"open-and-navigate-to-tab"
Changelog
CHANGELOG entry: null
Related issues
Fixes: #41473
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Small behavioral change limited to MV3 UI configuration after
failed/dropped transactions; risk is low and mainly involves ensuring
the action popup still points to the Activity tab without unintended
side effects.
Overview
Prevents the side panel from reloading on failed/dropped transactions
by removing the MV3
browser.sidePanel.setOptionsupdates thatpreviously changed the side panel path to
?tab=activity(and back whencleared).
Failed-transaction handling now only updates the extension action
popup (
browser.action.setPopup) while keeping the badge count/clearingbehavior unchanged.
Reviewed by Cursor Bugbot for commit
47de11d. Bugbot is set up for automated
code reviews on this repo. Configure
here.