feat: open to Activity tab on failed transaction#41531
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
commented
Apr 7, 2026
| ENVIRONMENT_TYPE_SIDEPANEL, | ||
| PLATFORM_FIREFOX, | ||
| MESSAGE_TYPE, | ||
| POPUP_FILE, |
n3ps
commented
Apr 7, 2026
| function onTransactionFailed() { | ||
| failedTxCount += 1; | ||
| const popupFile = isFirefox ? 'popup.html' : 'popup-init.html'; | ||
| function setClientOpenOptions(tab) { |
Contributor
Author
There was a problem hiding this comment.
- Extracted from call sites: onTransactionFailed and clearFailedTxBadge
n3ps
commented
Apr 7, 2026
| } | ||
|
|
||
| function onTransactionFailed() { | ||
| if (isClientOpenStatus()) { |
Contributor
Author
There was a problem hiding this comment.
- Don't run this unless the extension is closed
n3ps
commented
Apr 7, 2026
| try { | ||
| if (isManifestV3) { | ||
| browser.action.setPopup({ popup: `${popupFile}?tab=activity` }); | ||
| browser.action.setPopup({ popup }); |
Contributor
Author
There was a problem hiding this comment.
Set the next popup action
n3ps
commented
Apr 7, 2026
| if (isManifestV3) { | ||
| browser.action.setPopup({ popup: `${popupFile}?tab=activity` }); | ||
| browser.action.setPopup({ popup }); | ||
| browser.sidePanel?.setOptions?.({ path: sidepanelPath }); |
Contributor
Author
There was a problem hiding this comment.
Set sidepanel option on next open
n3ps
changed the title
n3ps
changed the title
|
vinnyhoward
approved these changes
Apr 7, 2026
Contributor
Builds ready [c4c3bbd]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Apr 8, 2026
metamaskbot
added
the
release-13.27.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a transaction fails while the extension is closed, a red badge now shows on the extension icon.
This PR restores ensures it opens directly to the Activity tab.
Changelog
CHANGELOG entry: feat: open to Activity tab when badge is clicked on failed transaction
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Moderate risk because it changes how the extension action popup (and MV3 side panel path) are configured at runtime, which could alter what UI opens across browsers if paths/query params are wrong.
Overview
Ensures that when a transaction fails while the UI is closed, clicking the extension icon opens directly to the Activity tab by dynamically setting the action popup URL (and resetting it when the failure badge is cleared).
This refactors action URL handling into
setClientOpenOptions, adds shared constants forpopup.html/popup-init.html/sidepanel.html, and updates environment-type detection to use those constants (including setting MV3sidePaneloptions where supported).Reviewed by Cursor Bugbot for commit c4c3bbd. Bugbot is set up for automated code reviews on this repo. Configure here.