fix: standardize account type analytics

[grvgoel81]

Description

There are inconsistencies in how the account_type value is recorded in analytics events. Current values include hardcoded strings like 'social', 'default_google', 'social_import', and template literals like metamask_${provider}. This PR standardizes all account_type values to use the AccountType enum, ensuring consistency across all analytics metrics.

Changes:

• OAuthService.ts — Replaced default_${authConnection} with getSocialAccountType() for SOCIAL_LOGIN_FAILED event.
• OAuthRehydration — Replaced hardcoded 'social' values with accountType from Redux (selectOnboardingAccountType), falling back to AccountType.Social
• ChoosePassword — Replaced metamask_${provider} with getSocialAccountType(provider, false) and AccountType.Metamask

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TO-593

Manual testing steps

Feature: account_type analytics standardization

  Scenario: New wallet creation sends correct account_type
    Given the user is on the onboarding screen
    When user creates a new wallet via "Create a new wallet"
    Then WALLET_SETUP_COMPLETED event has account_type "metamask"

  Scenario: SRP import sends correct account_type
    Given the user is on the onboarding screen
    When user imports wallet via Secret Recovery Phrase
    Then WALLET_SETUP_COMPLETED event has account_type "srp_import"

  Scenario: Social login (Google) sends correct account_type
    Given the user is on the onboarding screen
    When user creates wallet via Google login (new user)
    Then WALLET_CREATION_ATTEMPTED event has account_type "metamask_google"

  Scenario: Social login failure sends correct account_type
    Given the user is on the onboarding screen
    When user attempts Google login and it fails
    Then SOCIAL_LOGIN_FAILED event has account_type "metamask_google"

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low functional risk since changes are limited to analytics/tracing payload values and related tests, plus a small dependency patch bump. Main risk is metrics/dashboard continuity if downstream expects the old inconsistent account_type strings.

Overview
Standardizes onboarding analytics/tracing account_type values by routing all emitted values through the AccountType enum and getSocialAccountType() helper, replacing hardcoded strings/template literals across wallet creation, SRP import, OAuth rehydration, and social login failure tracking.

Adds coverage in ChoosePassword, ImportFromSecretRecoveryPhrase, and OAuthService tests to assert the new account_type mappings (including social vs rehydration and SRP vs social import). Also bumps @xmldom/xmldom from ^0.8.10 to ^0.8.12.

^{Reviewed by Cursor Bugbot for commit e3056c5. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[tylerc-consensys]

Seems like Imported is unused?

[grvgoel81]

Seems like Imported is unused?

It is used in getSocialAccountType for existing users without a Google/Apple mapping and in ImportSRP module too.

[grvgoel81]

getSocialAccountType(authConnection, false) — should this be userClickedRehydration instead of false?

The existingUser param is hardcoded to false, but userClickedRehydration is already available and sent as is_rehydration in the same event. This means both new and returning user failures emit metamask_google - the imported_google/imported_apple values never get used for failure events. Seems like it should be:

account_type: getSocialAccountType(authConnection, userClickedRehydration)

Resolved.

[lwin-kyaw]

Just wanna inform that we don't have this event, Use Different Login Method Clicked in the schema.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, FlaskBuildTests
• Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
• Risk Level: high
• AI Confidence: %

click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details