Skip to content

feat: add money account poc#27744

Draft
Jwhiles wants to merge 9 commits intomainfrom
add-money-account
Draft

feat: add money account poc#27744
Jwhiles wants to merge 9 commits intomainfrom
add-money-account

Conversation

@Jwhiles
Copy link
Copy Markdown

@Jwhiles Jwhiles commented Mar 20, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@Jwhiles

@Jwhiles Jwhiles force-pushed the add-money-account branch from 88e8580 to 3159ead Compare March 20, 2026 14:23
@Jwhiles Jwhiles force-pushed the add-money-account branch from 7385cf7 to de62e57 Compare March 27, 2026 13:44
@github-actions
Copy link
Copy Markdown
Contributor

Feature Flag Registry Check

This PR introduces feature flag references that are not yet registered in the
feature flag registry.

Unregistered flags

Flag Referenced in
moneyAccounts app/core/Engine/controllers/money-account-service/money-account-service-init.ts
How to fix

Add an entry for each flag in tests/feature-flags/feature-flag-registry.ts:

myNewFlag: {
  name: 'myNewFlag',
  type: FeatureFlagType.Remote,
  inProd: false,
  productionDefault: false,
  status: FeatureFlagStatus.Active,
},

Set inProd and productionDefault to match the current production values from the
client-config API.

If you access the flag via a constant (e.g. remoteFeatureFlags[MY_CONSTANT]), also add the constant to
.github/scripts/known-feature-flag-constants.ts
so the CI check can resolve it.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
53.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants