Skip to content

chore: bump @metamask/tron-wallet-snap to ^1.25.0#27922

Merged
mikesposito merged 1 commit intomainfrom
mikesposito/fix/trc20-transfer
Mar 31, 2026
Merged

chore: bump @metamask/tron-wallet-snap to ^1.25.0#27922
mikesposito merged 1 commit intomainfrom
mikesposito/fix/trc20-transfer

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Mar 25, 2026

Description

@metamask/tron-wallet-snap has been updated to ^1.25.0 to include the following changes:

## [1.25.0]

### Changed

- Optimize account discovery by using a lightweight activity check (`limit=1`) instead of fetching full transaction history ([#252](https://github.com/MetaMask/snap-tron-wallet/pull/252))

### Fixed

- Avoid `onAmountInput` fee estimation failures by skipping fee validation until a recipient address is available ([#259](https://github.com/MetaMask/snap-tron-wallet/pull/259))
- Assert transaction structure at all entry points, rejecting malformed transactions ([#237](https://github.com/MetaMask/snap-tron-wallet/pull/237))
- Disable scanning of unsupported contract types, preventing incorrect security alerts from blocking user flows ([#238](https://github.com/MetaMask/snap-tron-wallet/pull/238))
  - Supported transactions are those single-contract interaction transactions of the following types: `TransferContract`, `CreateSmartContract`, `TriggerSmartContract`.
  - Unsupported transactions will show empty estimated changes and allow the user to proceed without blocking the confirmation.
- Correctly fetch and return staking rewards ([#242](https://github.com/MetaMask/snap-tron-wallet/pull/242))
- Fix revert simulation error when sending TRC20 tokens ([#261](https://github.com/MetaMask/snap-tron-wallet/pull/261))
- Fix infinite loading during fee estimation ([#258](https://github.com/MetaMask/snap-tron-wallet/pull/258))
  - The issue was caused by a deadlock during cache updates of chain parameters.

Changelog

CHANGELOG entry: Fixed a bug that was causing issues with TRC20 token transfers

Related issues

Fixes:

Manual testing steps

  1. Initiate a TRC20 token transfer (e.g., USDT)
  2. Type in a valid recipient address and amount
  3. Observe that the button does not show an error
  4. Click the button to proceed with the transfer
  5. Observe that the confirmation screen is shown with no simulation error

Screenshots/Recordings

Before

After

mobile.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dependency-only version bump with no direct code changes in this repo; risk is limited to any upstream behavioral changes in the TRON snap affecting TRON-specific flows.

Overview
Bumps @metamask/tron-wallet-snap from 1.24.0 to ^1.25.0 in package.json, updating the resolved version to 1.25.0 in yarn.lock.

No application code changes; this is a dependency-only update intended to pick up upstream fixes and behavior changes in the TRON snap.

Written by Cursor Bugbot for commit 0a08885. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Mar 25, 2026
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.24.0 ⏵ 1.25.0100 +110096 +199 +1100

View full report

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk size-XS labels Mar 25, 2026
@mikesposito mikesposito added team-networks Networks team and removed team-core-platform Core Platform team labels Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@michele Esposito

GitHub can't find an account for Michele Esposito.
You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 30, 2026
maxime-oe
maxime-oe previously approved these changes Mar 30, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 30, 2026
@mikesposito mikesposito enabled auto-merge March 30, 2026 15:06
@github-actions github-actions bot added risk-high Extensive testing required · High bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 31, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@mikesposito mikesposito force-pushed the mikesposito/fix/trc20-transfer branch from b3256de to ae748bc Compare March 31, 2026 08:49
@github-actions github-actions bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Mar 31, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@mikesposito
Copy link
Copy Markdown
Member Author

I have read the CLA Document and I hereby sign the CLA

@mikesposito mikesposito force-pushed the mikesposito/fix/trc20-transfer branch from bc2e3ce to 0a08885 Compare March 31, 2026 09:55
@github-actions github-actions bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: FlaskBuildTests
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR bumps @metamask/tron-wallet-snap from 1.24.0 to ^1.25.0 (resolving to 1.25.0). This is a minor version bump of a preinstalled snap used for Tron blockchain wallet functionality (TRX staking/unstaking/claiming). Key findings:

  1. Scope: The tron-wallet-snap is gated behind ///: BEGIN:ONLY_INCLUDE_IF(tron) build flags, so it only ships in Tron-enabled builds. It's used in app/lib/snaps/preinstalled-snaps.ts, app/core/SnapKeyring/TronWalletSnap.ts, and Earn/Tron staking hooks.

  2. FlaskBuildTests: This tag covers preinstalled snaps, snap lifecycle, and snap capabilities — directly relevant to validating that the updated tron-wallet-snap version works correctly as a preinstalled snap.

  3. No broader impact: No core controllers, navigation, shared UI components, or other feature areas are affected. The change is isolated to the snap package version.

  4. No other tags needed: The tron-wallet-snap is not related to EVM confirmations, network management, identity sync, trading flows, or other feature areas covered by other tags.

Performance Test Selection:
The change is a minor version bump of the tron-wallet-snap package. This does not affect UI rendering, data loading, account/network list components, critical user flows, or app startup/initialization in any performance-sensitive way. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

@mikesposito mikesposito added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 6bb954e Mar 31, 2026
95 checks passed
@mikesposito mikesposito deleted the mikesposito/fix/trc20-transfer branch March 31, 2026 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2026
@weitingsun weitingsun added release-7.73.0 Issue or pull request that will be included in release 7.73.0 and removed release-100.10.0 labels Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-medium Moderate testing recommended · Possible bug introduction risk size-XS team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants