refactor: remove ScreenComponent any cast from Ramp Deposit routes

[asalsys]

Description

Migrate the local MainRoutes component in Ramp Deposit routes from prop-based route access to useRoute() hook, eliminating the type ScreenComponent = React.ComponentType<any> escape hatch.

Part of the React Navigation v6 migration effort to remove no-explicit-any violations from route files.

Changes:

• routes/index.tsx: Switch MainRoutes to useRoute(), remove MainRoutesProps, ScreenComponent alias, and cast

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A — pure refactoring with no user-facing behavior change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

---

Note

Low Risk
Low risk refactor limited to navigation param plumbing; behavior should remain unchanged aside from potential typing/runtime differences if the route context is misconfigured.

Overview
Refactors app/components/UI/Ramp/Deposit/routes/index.tsx so MainRoutes no longer accepts a route prop and instead pulls DepositNavigationParams from React Navigation via useRoute().

This removes the local MainRoutesProps typing and updates imports accordingly, aiming to simplify typing and reduce any-style escape hatches during the React Navigation v6 migration.

^{Written by Cursor Bugbot for commit b1db237. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

ScreenComponent any cast not removed as intended

Low Severity

The type ScreenComponent = React.ComponentType<any> alias (line 56), its eslint-disable comment (line 55), and the as ScreenComponent cast on line 205 were all supposed to be removed per the PR title and description, but they remain. Now that MainRoutes accepts no props, the cast is unnecessary — a bare () => JSX.Element is already assignable to the navigator's component prop. The no-explicit-any violation this PR was designed to eliminate is still present.

Additional Locations (1)

• app/components/UI/Ramp/Deposit/routes/index.tsx#L204-L205

 

[asalsys]

will do this in clean up pr

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeRamps
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 92%

click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a minimal internal refactor in the Deposit (on-ramp) routing component. It replaces prop-based route access ({ route }: MainRoutesProps) with the useRoute() hook from @react-navigation/native. The behavior is functionally identical — route.params is still accessed the same way, just via a hook instead of a prop. No navigation structure, business logic, or other components are affected. SmokeRamps is the appropriate tag as it covers fiat on-ramp/off-ramp features, which is exactly what the Deposit flow is part of. No other tags are needed since this change is isolated to the Deposit routing component and doesn't touch confirmations, accounts, networks, or any other feature areas.

Performance Test Selection:
This is a pure refactor replacing prop-based route access with the useRoute() hook. There is no change to rendering logic, data loading, state management, or any performance-sensitive code path. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details