Skip to content

chore: Add group to upload testflight workflow and show build number#28133

Open
Cal-L wants to merge 3 commits intomainfrom
chore/MCWP-447-add-groups-to-testflight-workflow
Open

chore: Add group to upload testflight workflow and show build number#28133
Cal-L wants to merge 3 commits intomainfrom
chore/MCWP-447-add-groups-to-testflight-workflow

Conversation

@Cal-L
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L commented Mar 31, 2026

Description

This change adds Acolad Product QA to the upload to test flight workflow. It also displays the build number to better help users better identify the uploaded build

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-447

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk CI-only change limited to GitHub Actions workflow wiring and summary output formatting, with no runtime/app code impact. Main risk is miswired outputs causing missing build numbers in downstream workflows.

Overview
The reusable build.yml workflow now exports a build_version output (native build number from the version-bump) and threads it through the prepare job outputs.

The upload-to-testflight.yml workflow adds the Acolad Product QA TestFlight group option and updates the step summary to display the build number via needs.build.outputs.build_version (instead of parsing Android versionCode), with minor renaming/formatting of the summary job.

Written by Cursor Bugbot for commit 290762c. This will update automatically on new commits. Configure here.

@Cal-L Cal-L requested review from a team as code owners March 31, 2026 03:40
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 31, 2026
@github-actions github-actions bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@Cal-L Cal-L enabled auto-merge March 31, 2026 18:30
weitingsun
weitingsun previously approved these changes Mar 31, 2026
andrepimenta
andrepimenta previously approved these changes Mar 31, 2026
@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Mar 31, 2026
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 31, 2026
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Mar 31, 2026
@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 31, 2026
@Cal-L Cal-L added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 31, 2026
@Cal-L Cal-L dismissed stale reviews from andrepimenta and weitingsun via 290762c March 31, 2026 22:03
@Cal-L Cal-L enabled auto-merge March 31, 2026 22:03
@github-actions github-actions bot added size-S risk-low Low testing needed · Low bug introduction risk and removed size-XS risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The two changed files are purely CI/CD workflow files with no impact on app source code, E2E test infrastructure, or app behavior:

  1. .github/workflows/build.yml: Adds a build_version output to the workflow_call interface so callers can consume the native build number. Also passes this value through to the prepare job. This is a plumbing change to expose an existing value as a workflow output — no app code is affected.

  2. .github/workflows/upload-to-testflight.yml:

    • Adds 'Acolad Product QA' as a new allowed TestFlight distribution group
    • Renames the summary job name
    • Refactors the step summary to use needs.build.outputs.build_version (the new output from build.yml) instead of parsing android/app/build.gradle directly
    • Minor formatting changes to the summary table

Neither file touches: app source code, test files, E2E test page objects, Detox configuration, navigation, controllers, or any shared component. These are purely CI/CD pipeline changes affecting build distribution and summary reporting. No E2E tests need to run to validate these changes.

Performance Test Selection:
No app source code changes were made. The changes are limited to CI/CD workflow files affecting build version propagation and TestFlight group configuration. There is no impact on app rendering, data loading, startup, or any other performance-sensitive area.

View GitHub Actions results

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

echo "| **Source branch** | ${{ inputs.source_branch }} |"
echo "| **Build name** | main-${{ inputs.environment || 'rc' }} |"
echo "| **Build version** | ${BUILD_VERSION} |"
echo "| **Build number** | ${{ needs.build.outputs.build_version }} |"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate workflow ref in summary table

Low Severity

upload-to-testflight.yml writes the Workflow ref row twice in the same summary table. This introduces redundant output and inconsistent formatting for the same field, which makes the upload summary noisier and harder to scan when validating release metadata.

Fix in Cursor Fix in Web

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed risk-low Low testing needed · Low bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

Status: Review finalised - Ready to be merged

Development

Successfully merging this pull request may close these issues.

4 participants