Skip to content

test: added new sentry attributes#28138

Merged
javiergarciavera merged 4 commits intomainfrom
MMQA-1653-performance-sentry-attributes
Mar 31, 2026
Merged

test: added new sentry attributes#28138
javiergarciavera merged 4 commits intomainfrom
MMQA-1653-performance-sentry-attributes

Conversation

@javiergarciavera
Copy link
Copy Markdown
Contributor

@javiergarciavera javiergarciavera commented Mar 31, 2026

Description

Added new scenario attributes to Sentry:

  • Browserstack recording link
  • Github action link
  • Scenario team owner

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new external BrowserStack API calls and extra metadata to Sentry transaction payloads during test teardown, which could impact reporting or introduce intermittent failures if env/config changes. Core app logic is unaffected.

Overview
E2E performance runs now publish richer Sentry transactions by mirroring key scenario attributes (project/provider/team/status/retry/build variant/device/file path) into both Sentry tags and each step span.data for easier filtering and correlation.

The performance fixture now optionally fetches and attaches a BrowserStack session recording URL (derived from the test sessionId annotation and BrowserStack session details) and the Sentry publisher also includes GitHub Actions run/job metadata (from GITHUB_* env vars) in extra and span data.

Tests were updated to cover the new payload fields and to manage the additional GitHub env vars during setup/teardown.

Written by Cursor Bugbot for commit 8b2546d. This will update automatically on new commits. Configure here.

@javiergarciavera javiergarciavera self-assigned this Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Mar 31, 2026
@github-actions github-actions bot added size-S risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@javiergarciavera javiergarciavera requested a review from a team as a code owner March 31, 2026 08:20
@github-actions github-actions bot added size-M risk-low Low testing needed · Low bug introduction risk and removed size-S risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@javiergarciavera javiergarciavera added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 31, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
All three changed files are exclusively within the performance testing infrastructure (tests/framework/fixtures/performance/ and tests/reporters/providers/sentry/). No app source code (app/) is modified. The changes enhance how performance test results are reported to Sentry by: (1) adding BrowserStack recording URLs to Sentry payloads, (2) adding GitHub CI job URLs and job names to Sentry payloads, (3) adding a test_team tag, (4) mirroring scenario-level attributes into each span's data. These are purely observability/reporting improvements to the performance test pipeline. Since no Detox E2E test code or app code is changed, no Detox E2E test tags need to run.

Performance Test Selection:
The performance-fixture.ts is the base fixture used by ALL performance tests. Changes to this fixture (refactoring session ID extraction, adding BrowserStack recording URL fetching, passing new fields to the Sentry publisher) affect the test lifecycle for every performance test. Running all performance test tags validates that: (1) the refactored session ID extraction still works correctly, (2) the BrowserStack recording URL is properly fetched and passed through, (3) the enhanced Sentry payload is correctly constructed and published, (4) no regressions were introduced in the fixture teardown logic. Since the fixture is shared infrastructure, all performance test categories should run to ensure the changes work end-to-end.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@javiergarciavera javiergarciavera added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit c5c4623 Mar 31, 2026
63 checks passed
@javiergarciavera javiergarciavera deleted the MMQA-1653-performance-sentry-attributes branch March 31, 2026 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2026
@weitingsun weitingsun added release-7.73.0 Issue or pull request that will be included in release 7.73.0 and removed release-100.10.0 labels Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-low Low testing needed · Low bug introduction risk size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants