test: improve TabBarComponent retry logic to reduce trade smoke flakiness

[dylanbutler1]

Description

The trade-ios-smoke-1 CI job has been flaky since ~Feb 26. Investigation traced one contributing cause to tapAccountsMenu() (formerly tapSettings() via PR #26568), which wrapped a multi-step navigation sequence (wallet tap → assert wallet → hamburger tap → assert menu) in a single executeWithRetry block. When any intermediate step failed, the retry restarted the entire sequence from scratch, potentially tapping wallet mid-navigation and leaving the app in a broken state.

This PR makes three improvements to TabBarComponent:

1. Split tapAccountsMenu() into two separately retried steps: First calls this.tapWallet() (which already has its own retry + validation pattern), then retries only the hamburger→accounts menu step independently. A failure opening the accounts menu no longer restarts wallet navigation.

2. Add retry logic to tapActions(): Was a bare UnifiedGestures.waitAndTap() without any retry or validation. Now wrapped in executeWithRetry with a visibility assertion on the actions bottom sheet swap button.

3. Add retry logic to tapTrade(): Same treatment as tapActions() — wrapped in executeWithRetry with validation.

Both tapActions() and tapTrade() now follow the same resilient pattern used by tapWallet(), tapExploreButton(), tapActivity(), and tapRewards().

Changelog

CHANGELOG entry: null

Related issues

Refs: #26568

Manual testing steps

Feature: Trade smoke E2E reliability

  Scenario: swap/bridge/stake tests navigate to settings without flaking
    Given a CI environment running trade-ios-smoke-1

    When swap-action-smoke, bridge-action-smoke, or stake-action-smoke tests
         call tapSettings() or tapActions()
    Then navigation succeeds reliably without retry-induced broken state

Screenshots/Recordings

N/A — no UI changes, E2E test infrastructure only.

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud