feat: migrate FundActionMenu to BottomSheet#28159
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
left a comment
There was a problem hiding this comment.
Excellent work @kirillzyusko! Removing the unnecessary mocking is really nice! Left one small comment but otherwise LGTM!
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
SmokeRamps is selected because FundActionMenu is the primary entry point for buy/sell (ramp) flows. The BottomSheet migration and SmokeWalletPlatform is selected because FundActionMenu is also accessed from the wallet home actions and asset details screens, which are core wallet platform features. The No other tags are needed — the changes don't touch swap/bridge confirmations directly, don't affect network management, accounts, or identity features. Performance Test Selection: |
|
✅ E2E Fixture Validation — Schema is up to date |
|




Description
Migrate
BottomSheetinFundActionMenuto DSRN package usage.Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-639
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.15.01.54.mov
After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.14.59.17.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Swaps the
BottomSheetimplementation and changes back-navigation wiring, which could affect dismissal/navigation behavior at runtime. Updates are localized toFundActionMenuplus its unit tests.Overview
Migrates
FundActionMenuto useBottomSheetfrom@metamask/design-system-react-nativeinstead of the deprecated in-repo component, and wires bottom-sheet dismissal to navigation by passingnavigation.goBackinto the sheet.Updates the test suite to stop mocking the old
BottomSheet, mock safe-area context for the new implementation, and assert against a new bottom-sheettestID(fund-action-menu-bottom-sheet).Written by Cursor Bugbot for commit 6d9c9ef. This will update automatically on new commits. Configure here.