Skip to content

feat: migrate FundActionMenu to BottomSheet#28159

Merged
kirillzyusko merged 4 commits intomainfrom
feat/migrate-fund-action-menu
Apr 2, 2026
Merged

feat: migrate FundActionMenu to BottomSheet#28159
kirillzyusko merged 4 commits intomainfrom
feat/migrate-fund-action-menu

Conversation

@kirillzyusko
Copy link
Copy Markdown
Contributor

@kirillzyusko kirillzyusko commented Mar 31, 2026

Description

Migrate BottomSheet in FundActionMenu to DSRN package usage.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-639

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.15.01.54.mov

After

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.14.59.17.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Swaps the BottomSheet implementation and changes back-navigation wiring, which could affect dismissal/navigation behavior at runtime. Updates are localized to FundActionMenu plus its unit tests.

Overview
Migrates FundActionMenu to use BottomSheet from @metamask/design-system-react-native instead of the deprecated in-repo component, and wires bottom-sheet dismissal to navigation by passing navigation.goBack into the sheet.

Updates the test suite to stop mocking the old BottomSheet, mock safe-area context for the new implementation, and assert against a new bottom-sheet testID (fund-action-menu-bottom-sheet).

Written by Cursor Bugbot for commit 6d9c9ef. This will update automatically on new commits. Configure here.

@kirillzyusko kirillzyusko self-assigned this Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kirillzyusko kirillzyusko marked this pull request as ready for review March 31, 2026 12:15
@kirillzyusko kirillzyusko added the team-design-system All issues relating to design system in Mobile label Mar 31, 2026
@github-actions github-actions bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @kirillzyusko! Removing the unnecessary mocking is really nice! Left one small comment but otherwise LGTM!

@github-actions github-actions bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 31, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirillzyusko kirillzyusko enabled auto-merge April 1, 2026 15:57
@github-actions github-actions bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeRamps, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are focused on the FundActionMenu component:

  1. BottomSheet migration: The BottomSheet import was moved from the internal component library (../../../component-library/components/BottomSheets/BottomSheet) to @metamask/design-system-react-native. This is a component library migration that could affect the bottom sheet's behavior (open/close animations, dismissal, gesture handling).

  2. Added goBack prop: The new BottomSheet from the design system requires an explicit goBack prop for navigation dismissal. This is a behavioral change — the bottom sheet now uses navigation.goBack when dismissed, which could affect how the FundActionMenu closes in various flows.

  3. Added testID: Minor change for test identification.

SmokeRamps is selected because FundActionMenu is the primary entry point for buy/sell (ramp) flows. The BottomSheet migration and goBack behavior change could affect how the ramp flow initiates and how the menu dismisses.

SmokeWalletPlatform is selected because FundActionMenu is also accessed from the wallet home actions and asset details screens, which are core wallet platform features. The goBack navigation change could affect wallet navigation flows.

No other tags are needed — the changes don't touch swap/bridge confirmations directly, don't affect network management, accounts, or identity features.

Performance Test Selection:
The changes are a component library migration (BottomSheet source change) and addition of a navigation prop. There is no data loading, list rendering, state management, or initialization change that would impact app performance metrics. No performance tests are needed.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@kirillzyusko kirillzyusko added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 8e47e34 Apr 2, 2026
93 of 95 checks passed
@kirillzyusko kirillzyusko deleted the feat/migrate-fund-action-menu branch April 2, 2026 00:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-medium Moderate testing recommended · Possible bug introduction risk size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants