Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@SocketSecurity ignore npm/@metamask-previews/social-controllers@0.0.0-preview-ac7a6cc51 |
app/components/Views/Homepage/Sections/TopTraders/hooks/useTopTraders.ts
Show resolved
Hide resolved
app/components/Views/Homepage/Sections/TopTraders/utils/formatPnl.ts
Outdated
Show resolved
Hide resolved
app/components/Views/Homepage/Sections/TopTraders/hooks/useTopTraders.ts
Show resolved
Hide resolved
app/components/Views/Homepage/Sections/TopTraders/hooks/useTopTraders.ts
Outdated
Show resolved
Hide resolved
app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx
Show resolved
Hide resolved
app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx
Show resolved
Hide resolved
app/components/Views/Homepage/Sections/TopTraders/hooks/useTopTraders.ts
Outdated
Show resolved
Hide resolved
app/components/Views/Homepage/Sections/TopTraders/components/NetworkFilterButton.tsx
Show resolved
Hide resolved
app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.tsx
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore npm/@metamask/social-controllers@0.1.0 |
|
|
✅ E2E Fixture Validation — Schema is up to date |




Description
Wires up the Social Leaderboard to live data from the Social API.
Integrate the social-controllers (SocialService + SocialController) into the Engine, adds useTopTraders hook using useQuery from @metamask/react-data-query to fetch leaderboard data through the Data Services pattern.
Also adds the homepage TopTradersSection (horizontal card carousel) and the full TopTradersView (ranked list) with skeleton loading states.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Integrates a new
SocialService/SocialControllerinto the Engine and begins consuming a new Social API endpoint, which can affect app startup and network behavior if misconfigured. UI changes are localized but introduce new loading/empty-state behavior and follow toggling logic.Overview
Adds a live Social Leaderboard data path by integrating
@metamask/social-controllersinto the Engine (newSocialService+SocialController, messengers, state hydration, and registration inDATA_SERVICES), plus a configurableSOCIAL_API_URLin build/env config.Replaces the homepage
TopTradersSectionplaceholder with a real, refreshable carousel fed by a newuseTopTradershook (via@metamask/react-data-query), including skeleton loading states and a local Follow/Following toggle.Builds out
TopTradersViewto render the full ranked list with skeleton rows and a network filter UI (bottom sheet wiring), and adds supporting components/utilities (TopTraderCard,TraderRow,formatPnl) and expanded test coverage for the new hook/components and updated section behavior.Written by Cursor Bugbot for commit 5554c47. This will update automatically on new commits. Configure here.