Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-wallet-standard
…compatibility Normalize WalletConnect Tron requests to canonical Snap methods and sanitize params for JSON-RPC validity. Expand Tron session chain/account compatibility to support both decimal and hex CAIP references so dapps and wallet stay interoperable. Made-with: Cursor
Ensure tron signTransaction requests execute with metamask origin and adapt signature-only Snap results into a full signed transaction payload expected by WalletConnect dapps. Made-with: Cursor
Olivier-BB
force-pushed
the
Wallet-Connect
branch
from
d4f9a90 to
5709a36
Compare
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5709a36. Configure here.
| // should be multichain/tron-aware. WalletKit rejects these emits and | ||
| // this blocks the connection flow. | ||
| return; | ||
| } |
There was a problem hiding this comment.
updateSession early return breaks all EVM-only sessions
High Severity
The guard if (!mergedNamespaces.tron?.chains?.length) returns early for every session that lacks a Tron namespace, which includes all standard EVM-only WalletConnect connections. This prevents web3Wallet.updateSession() from being called and blocks chainChanged event emission for pure EVM dApps. The comment says the intent is to protect "multichain/tron-aware" sessions, but the condition triggers unconditionally whenever Tron chains are absent, silently breaking chain switching for the majority of WalletConnect sessions.
Reviewed by Cursor Bugbot for commit 5709a36. Configure here.
|
|
✅ E2E Fixture Validation — Schema is up to date |
3 participants
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
High Risk
Extends WalletConnect session/permission handling beyond EVM and adds Snap-based routing for Tron requests, touching connection, session update, and event emission paths that are central to dapp interoperability.
Overview
Adds WalletConnect multichain (Tron) support by expanding permissions and session namespaces beyond
eip155, including a newWalletConnectMultiChainConnectorfor CAIP chain normalization and safechainChangedemission decisions.WalletConnect2Sessionnow subscribes to store chain changes to update WC sessions, routes non-EVM requests (feature-flaggedtron) to the Tron Snap viahandleSnapRequest, and updates redirect behavior to be namespace-aware viaREDIRECT_METHODS_BY_NAMESPACE.Improves robustness/observability around WC QR/deeplink flows (extra logging, WC2 enablement checks, init/getInstance timeout, and cleanup of broken restored sessions), and updates
Permissionsdefaults andgetPermittedChainsto return scopes across namespaces (including optional Tron scope when enabled).Reviewed by Cursor Bugbot for commit 5709a36. Bugbot is set up for automated code reviews on this repo. Configure here.