chore: Add skip build to upload to testflight

[weitingsun]

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Changes the iOS TestFlight upload pipeline and artifact naming/parameterization in GitHub Actions, which can break release automation if inputs/artifacts don’t line up. No production app code changes, but failures would block builds/uploads.

Overview
Refactors Runway’s iOS TestFlight step to reuse the dedicated upload-to-testflight.yml workflow, removing the previously inlined checkout/upload steps and summary job from runway-ota-build-core.yml.

Extends upload-to-testflight.yml with skip_build, build_name, custom summary title, and external distribution toggle, and updates job gating/branch cleanup so it can either build-and-upload or upload an existing IPA artifact (ios-ipa-{build_name}) within the same run.

^{Written by Cursor Bugbot for commit 0c1aa2b. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 97%

click to see 🤖 AI reasoning details

E2E Test Selection:
Both changed files are GitHub Actions CI/CD workflow files related to iOS TestFlight upload pipeline:

1. runway-ota-build-core.yml: Refactored to remove inline TestFlight upload logic (removed testflight-upload-summary and upload-ios-testflight jobs) and replaced with a call to the reusable upload-to-testflight.yml workflow. This is purely a CI pipeline restructuring.

2. upload-to-testflight.yml: Enhanced the reusable workflow with a skip_build input flag (to allow callers that already have an IPA artifact to skip the build step), added build_name, summary_title, and distribute_external inputs, and updated conditional job execution logic accordingly.

These changes are entirely within the CI/CD infrastructure for building and distributing iOS builds to TestFlight. They do not touch:

• Any application source code
• Any E2E test files or test infrastructure (Detox, fixtures, page objects)
• Any app configuration (package.json, metro.config.js, babel.config.js)
• Any controllers, Engine, or core modules
• Any UI components or navigation

No E2E tests are needed to validate these changes. The changes only affect how iOS builds are uploaded to TestFlight, which is a deployment concern unrelated to app functionality or test execution.

Performance Test Selection:
These are purely CI/CD workflow changes with no impact on app code, rendering, data loading, or any other aspect that could affect performance. No performance tests are warranted.

View GitHub Actions results

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

Missing distribute_external: false flips distribution behavior

High Severity

The old inline job explicitly passed "false" for distribute_external when calling upload-to-testflight.sh. The new reusable workflow call omits the distribute_external input, which defaults to true in upload-to-testflight.yml. This silently changes behavior from "upload only" to "distribute to external testers" for iOS RC and Production Runway builds. The workflow input description itself notes that false "avoids App Manager role requirement," so this change may also cause permission failures.

Additional Locations (1)

• .github/workflows/upload-to-testflight.yml#L40-L45

 

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud