Skip to content

fix(predict): wires homepage_positions entry_point on Predict Feed Viewed event#28561

Draft
ghgoodreau wants to merge 1 commit intomainfrom
fix/predict-feed-viewed-homepage-positions-entry-point
Draft

fix(predict): wires homepage_positions entry_point on Predict Feed Viewed event#28561
ghgoodreau wants to merge 1 commit intomainfrom
fix/predict-feed-viewed-homepage-positions-entry-point

Conversation

@ghgoodreau
Copy link
Copy Markdown
Contributor

The homepage PredictionsSection navigated to the PredictFeed without passing an entryPoint param, so Predict Feed Viewed never reported homepage_positions. Add handleViewAllFromPositions handler that passes entryPoint: HOMEPAGE_POSITIONS when View All is tapped from the positions section (default and positions-only modes).

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The homepage PredictionsSection navigated to the PredictFeed without
passing an entryPoint param, so Predict Feed Viewed never reported
homepage_positions. Add handleViewAllFromPositions handler that passes
entryPoint: HOMEPAGE_POSITIONS when View All is tapped from the
positions section (default and positions-only modes).
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions bot added the size-S label Apr 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants