Skip to content

feat(icons): add NoPhotography icon#28568

Open
brianacnguyen wants to merge 3 commits intomainfrom
cursor/new-no-photography-icon-9127
Open

feat(icons): add NoPhotography icon#28568
brianacnguyen wants to merge 3 commits intomainfrom
cursor/new-no-photography-icon-9127

Conversation

@brianacnguyen
Copy link
Copy Markdown
Contributor

Description

Add a new NoPhotography icon to the component library icon assets. This icon represents a camera with a slash through it, indicating that photography/camera access is blocked or not allowed.

This icon was requested by the design system team to support the "Camera access blocked" UI component in MetaMask Mobile.

Changelog

CHANGELOG entry: null

Related issues

Refs: Slack thread in #metamask-design-system

Manual testing steps

Feature: NoPhotography icon availability

  Scenario: Developer uses NoPhotography icon in a component
    Given the developer has imported Icon and IconName from the design system

    When the developer renders <Icon name={IconName.NoPhotography} />
    Then the no-photography icon should display correctly

Screenshots/Recordings

Before

N/A - New icon addition

After

The NoPhotography icon is now available in the icon library and can be used with:

import { Icon, IconName } from '@metamask/design-system-react-native';

<Icon name={IconName.NoPhotography} />

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Slack Thread

Open in Web Open in Cursor 

Add no-photography.svg icon to the component library assets.
This icon represents a camera with a slash through it, indicating
that photography/camera access is blocked or not allowed.

Co-authored-by: Brian August Nguyen <brianacnguyen@gmail.com>
@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@brianacnguyen brianacnguyen marked this pull request as ready for review April 8, 2026 20:22
@brianacnguyen brianacnguyen requested a review from a team as a code owner April 8, 2026 20:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen enabled auto-merge April 8, 2026 20:23
@github-actions github-actions bot added the risk-low Low testing needed · Low bug introduction risk label Apr 8, 2026
@github-actions github-actions bot removed the risk-low Low testing needed · Low bug introduction risk label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely additive to the icon component library:

  1. A new SVG asset no-photography.svg was added
  2. A new NoPhotography enum value was added to IconName in Icon.types.ts
  3. The new SVG was imported and mapped in Icon.assets.ts

No existing icons, enum values, or mappings were modified. The new NoPhotography icon is not yet used anywhere in the application (confirmed via codebase search — only referenced in the icon library files themselves). This is a non-breaking, additive change with zero impact on any existing user flows, features, or test scenarios. No E2E tests need to run for this change.

Performance Test Selection:
Adding a new SVG icon to the icon library has no measurable performance impact. The icon is not yet used anywhere in the app, so there is no rendering, loading, or state management impact to test.

View GitHub Actions results

@github-actions github-actions bot added the risk-low Low testing needed · Low bug introduction risk label Apr 8, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants