feat(STX-472): add gas-included metrics properties

[rarquevaux]

Description

Same changes than MetaMask/metamask-extension#41581

Changelog

CHANGELOG entry: add gas-included metrics properties

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk: adds a confirmation metrics side-effect alongside existing auto-selection logic and updates unit tests accordingly, with minimal impact on transaction behavior.

Overview
Adds confirmation metrics when useAutomaticGasFeeTokenSelect automatically picks a gas fee token. When auto-selection triggers, it now calls setConfirmationMetric with automatic_fee_token_selection: true and the selected token symbol, and expands the effect dependencies accordingly.

Updates useAutomaticGasFeeTokenSelect.test.ts to mock useConfirmationMetricEvents and assert metrics are emitted only when an automatic selection occurs (and not on other paths or rerenders).

^{Reviewed by Cursor Bugbot for commit 82c4bc8. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are confined to useAutomaticGasFeeTokenSelect.ts and its test file. The modification adds analytics metric tracking (via useConfirmationMetricEvents) when an automatic gas fee token is selected during the EIP-7702 gasless transaction flow. The core selection logic is unchanged — only a setConfirmationMetric call is added to record automatic_fee_token_selection and automatic_fee_token_selected properties when shouldSelect is true.

This hook is used in gas-fee-details-row.tsx within the confirmations component tree, specifically for the EIP-7702 advanced account abstraction feature (gas fee token payments). SmokeConfirmations covers 'advanced EIP-7702 account abstraction features like batch transactions and gas fee token payments', making it the directly relevant tag.

No other areas are impacted: no navigation changes, no controller changes, no shared components affected. The test file changes are unit test updates to verify the new analytics assertions. Risk is low since the functional behavior is unchanged.

Performance Test Selection:
The changes only add analytics metric tracking to an existing hook. No UI rendering changes, no data loading changes, no state management changes that would affect performance. The added setConfirmationMetric call is a lightweight analytics event and would not measurably impact performance.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details