chore: test design-tokens preview build of pure black [DO NOT MERGE]#28576
Draft
georgewrmarshall wants to merge 2 commits intomainfrom
Draft
chore: test design-tokens preview build of pure black [DO NOT MERGE]#28576georgewrmarshall wants to merge 2 commits intomainfrom
georgewrmarshall wants to merge 2 commits intomainfrom
Conversation
Testing MetaMask/metamask-design-system#1045 via preview package @metamask-previews/design-tokens@8.3.0-preview.dbe1fac
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - draft PR All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Updates the `@metamask/design-tokens` dependency to a preview build for testing purposes. This allows us to validate the changes in MetaMask/metamask-design-system#1045 before they are officially released.
Change: `@metamask/design-tokens ^8.3.0` → `npm:@metamask-previews/design-tokens@8.3.0-preview.dbe1fac`
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
```gherkin
Feature: design tokens preview testing
Scenario: user validates design token changes from upstream PR
Given the app is built with the preview design-tokens package
When user navigates through affected UI surfaces
Then the design token changes from MetaMask/metamask-design-system#1045 appear as expected
```
Screenshots/Recordings
Before
design-tokens.pure.black.before720.mov
After
design-tokens.pure.black.after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
UI theming changes are driven by a preview
@metamask/design-tokensbuild, which can have broad visual impact across the app but does not alter core business logic.Overview
Updates
@metamask/design-tokensto a@metamask-previews/design-tokens@8.3.0-preview.dbe1facbuild to validate upcoming design-system token changes.Refreshes a large set of Jest snapshots to match the new token output, primarily shifting common text/icon/button colors from
#131416to#141414(including somebackgroundColorchanges) across multiple UI surfaces (Snaps UI, Bridge, browser URL bar, account/asset views, etc.).Reviewed by Cursor Bugbot for commit 3cfd70c. Bugbot is set up for automated code reviews on this repo. Configure here.