fix: hide gas sponsorship badge for hardware wallets in bridge activity details

[dawnseeker8]

Description

When a hardware wallet (Ledger/QR) user initiates a swap on MON network and rejects signing on the device, the transaction is marked as failed but the isGasFeeSponsored flag on the transaction metadata is never cleared (the confirm callback that clears it only runs on actual confirmation). The BridgeTransactionDetails component then reads evmTxMeta.isGasFeeSponsored directly and incorrectly displays "Paid by MetaMask" in the gas fee field.

This PR adds an isHardwareAccount check in BridgeTransactionDetails so the "Paid by MetaMask" tag is only shown when the sender is not a hardware wallet. This mirrors the existing pattern used in gas-fee-details-row.tsx where gasless support (which excludes HW wallets) is checked before displaying the sponsored fee badge.

Changelog

CHANGELOG entry: Fixed a bug where "Paid by MetaMask" was incorrectly shown in transaction details for failed hardware wallet swaps on MON network

Related issues

Fixes: #28268

Manual testing steps

Feature: Gas sponsorship badge in bridge/swap activity details

  Scenario: Hardware wallet user views a failed swap on MON network
    Given user has a hardware wallet (Ledger or QR) connected
    And user is on the MON network

    When user initiates a swap and rejects signing on the hardware device
    And user opens the failed transaction in the activity log
    Then the gas fee field should show the actual gas fee amount
    And the "Paid by MetaMask" badge should NOT be displayed

  Scenario: Non-hardware wallet user views a sponsored swap transaction
    Given user has a software wallet connected
    And the transaction has isGasFeeSponsored set to true

    When user opens the transaction in the activity log
    Then the "Paid by MetaMask" badge should be displayed in the gas fee field

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk UI-logic change that only gates rendering of the gas sponsorship badge based on isHardwareAccount, plus focused unit tests; no transaction processing or persistence behavior is modified.

Overview
Prevents the "Paid by MetaMask" badge from being shown in BridgeTransactionDetails when the sender (txParams.from) is a hardware wallet by adding an isHardwareAccount check before rendering the sponsored-fee tag.

Adds unit tests that mock isHardwareAccount to verify the badge is hidden for sponsored hardware-wallet transactions and still shown for sponsored non-hardware transactions.

^{Reviewed by Cursor Bugbot for commit b2c72b0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3cdc719. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeTrade, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 86%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to the Bridge TransactionDetails component and its associated unit test (app/components/UI/Bridge/components/TransactionDetails/TransactionDetails.tsx). This component is part of the Bridge flow within the Trade feature. Bridge flows are explicitly covered under SmokeTrade. Since bridge execution requires on-chain transaction confirmations, SmokeTrade must be paired with SmokeConfirmations per the tag dependency rules.

There are no changes to controllers, Engine, network management, onboarding, identity, or multi-chain provider layers. The modification appears UI-scoped to bridge transaction detail rendering and related logic, so the primary risk is regression in bridge execution and confirmation display rather than broader wallet functionality.

Therefore:

• SmokeTrade ensures swap/bridge flows, quote handling, and completion verification still work.
• SmokeConfirmations ensures transaction confirmation UI and execution remain stable as bridge flows depend on them.

No other tags are required based on the impacted scope.

Performance Test Selection:
The changes are localized to a single UI component for displaying bridge transaction details and its unit test. There is no indication of changes to rendering-heavy lists, controllers, startup logic, asset loading, or critical performance paths. Therefore, no dedicated performance tests are required.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details