fix: perps withdraw metrics, UI, and fee display improvements

[dan437]

Description

Fixes several things with the Perps Withdraw to any token flow:

• mm_pay_quote_requested metric always false: The metric relied on hasSourceAmount which is never true for post-quote flows. Now uses isPostQuote as an alternative gate.
• mm_pay_time_to_complete_s missing: Falls back to the parent's submittedTime when no child transactions exist (gasless HyperLiquid withdrawals).
• Insufficient funds alert for excessive fees: On the confirmation screen, shows insufficient funds when total fees exceed the withdraw amount (gated on quotes being available).
• Unrealistic fallback fee displayed: Hides fee, time, and receive rows when no relay quotes exist, since the controller's raw gas fallback produces unrealistic values.
• Alert message positioning: Moved "This payment route isn't available" above the Receive token selector.
• Blue activity title: Overrides headerTintColor to text.default so the transaction details title is no longer blue.

Changelog

CHANGELOG entry: Fixed perps withdraw metrics tracking, hide rows when no quotes are available, and fixed blue title in transaction details

Related issues

Fixes: CONF-1159

Manual testing steps

Feature: Perps Withdraw

Scenario: user withdraws to BNB

• Given user has a perps balance
• When user initiates a perps withdraw to BNB
• Then transaction fee and receive amount display correctly
• Then mm_pay_quote_requested is true in the finalized event
• Then mm_pay_time_to_complete_s is present in the finalized event

Scenario: user enters tiny amount

• Given user is on the perps withdraw confirmation screen
• When user selects MUSD on Ethereum as receive token and enters $0.05 with withdraw
• Then fee and receive rows are hidden
• Then "No quotes" button is shown
• Then alert message appears above the Receive selector

Scenario: user views completed withdrawal in activity

• Given user has a completed perps withdrawal
• When user opens the transaction details
• Then the "Withdrawal" title is default text color, not blue

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Touches confirmation-screen fee/receive rendering and blocking alert logic for withdraws, plus metrics emission paths, which could affect user-visible values and analytics if quote/totals availability is misdetected.

Overview
Fixes Perps Withdraw confirmation UX by only showing fee/time/receive totals when relay quotes are loading or available, avoiding misleading fallback fee values; it also moves the inline AlertMessage above the receive/account selector.

Tightens quote-dependent calculations by returning empty values for BridgeFeeRow and ReceiveRow when there are no quotes, and adds a confirmation-only insufficient-funds check that blocks when total fees would consume the entire withdraw amount.

Improves MetaMask Pay metrics: mm_pay_quote_requested now triggers for post-quote flows (via useTransactionPayIsPostQuote), and mm_pay_time_to_complete_s falls back to the parent transaction submittedTime when no child submitted times exist. Also fixes the activity details header color by overriding headerTintColor to colors.text.default (with updated tests).

^{Reviewed by Cursor Bugbot for commit e33f629. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations, SmokeTrade
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains targeted bug fixes and logic improvements across several confirmation-related components:

1. SmokePerps (primary): useInsufficientPerpsBalanceAlert.ts has significant logic changes - now checks if fees exceed the withdraw amount on the confirmation screen. metamask-pay.ts fixes time-to-complete metrics for perps transactions (falls back to parent submittedTime). custom-amount-info.tsx wraps bridge/receive rows in hasQuoteResults guard which affects perps deposit/withdraw flows. Per tag description, SmokePerps requires SmokeWalletPlatform and SmokeConfirmations.

2. SmokeWalletPlatform (required by SmokePerps): Required as a dependent tag per SmokePerps description. Also relevant because transaction-details.tsx changes the header tint color in the activity/transaction details screen, which is part of transaction history display.

3. SmokeConfirmations (required by SmokePerps + SmokeTrade): Required as dependent tag. The custom-amount-info.tsx changes affect the confirmation UI for perps and bridge flows. bridge-fee-row.tsx and receive-row.tsx changes affect bridge confirmation display. useTransactionCustomAmount.ts changes affect quote metrics triggering in confirmations.

4. SmokeTrade (bridge/swap): bridge-fee-row.tsx and receive-row.tsx are directly used in bridge/swap confirmation flows. The hasQuotes guard changes prevent stale fee/receive data from showing during bridge operations. Per SmokeTrade description, SmokeConfirmations is also required.

The changes are bug fixes rather than architectural changes, reducing risk. No changes to core Engine controllers, navigation, or shared infrastructure that would affect unrelated test areas.

Performance Test Selection:
The changes are bug fixes to UI logic (quote guards, alert conditions, metrics fallbacks) and do not introduce new rendering paths, list components, or data loading patterns that would impact performance. No changes to account/network list components, app startup, or critical performance-sensitive flows.

View GitHub Actions results

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e33f629. Configure here.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details