Skip to content

feat: add collapsible FF section#28627

Open
sleepytanya wants to merge 11 commits intomainfrom
feature/about-screen-feature-flags
Open

feat: add collapsible FF section#28627
sleepytanya wants to merge 11 commits intomainfrom
feature/about-screen-feature-flags

Conversation

@sleepytanya
Copy link
Copy Markdown
Contributor

@sleepytanya sleepytanya commented Apr 9, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: adds a hidden (long-press) debug-only UI section and related unit tests, plus bumps build numbers across Android/iOS/CI with no changes to core wallet or security logic.

Overview
Adds a collapsible “Feature Flags” section to Settings > App Information (revealed after long-pressing the fox), showing the count of enabled remote flags, listing enabled flags alphabetically, and providing a “Copy All to Clipboard” action (JSON + confirmation alert).

Wires the screen to Redux via selectRemoteFeatureFlags and adds comprehensive unit tests covering visibility, expand/collapse behavior, ordering/filtering, and clipboard/alert interactions.

Bumps the mobile build number from 4138 to 4425 across Android versionCode, iOS CURRENT_PROJECT_VERSION, and Bitrise VERSION_NUMBER/FLASK_VERSION_NUMBER.

Reviewed by Cursor Bugbot for commit 280ecde. Bugbot is set up for automated code reviews on this repo. Configure here.

@sleepytanya sleepytanya requested a review from a team as a code owner April 9, 2026 22:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 9, 2026
@github-actions github-actions bot added size-M risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@sleepytanya sleepytanya added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 9, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@sleepytanya sleepytanya changed the title Add collapsible FF section test: add collapsible FF section Apr 9, 2026
@sleepytanya sleepytanya changed the title test: add collapsible FF section feat: add collapsible FF section Apr 9, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7f27880. Configure here.

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@sleepytanya sleepytanya force-pushed the feature/about-screen-feature-flags branch from a4b83c2 to 333c57d Compare April 9, 2026 22:56
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@metamaskbot metamaskbot requested a review from a team as a code owner April 9, 2026 23:53
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 10, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 10, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 10, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 5 changed files represent low-risk, isolated changes:

  1. android/app/build.gradle: Pure version code bump (4138 → 4425). No functional changes, no E2E test impact.

  2. ios/MetaMask.xcodeproj/project.pbxproj: Pure version code bump (4138 → 4425) across 6 build configurations. No functional changes, no E2E test impact.

  3. bitrise.yml: CI version number update (4138 → 4425) for main and Flask builds. No workflow logic changes, no E2E test impact.

  4. app/components/Views/Settings/AppInformation/index.js: Adds a Feature Flags display section to the App Information settings screen. This is a developer/debug feature hidden behind a long-press gesture on the fox icon. It reads remote feature flags from Redux state and displays enabled ones. This is completely isolated to the Settings > App Information screen, doesn't affect any shared components (navigation, modals, confirmations, accounts, networks), and has no impact on any user-facing flows tested by E2E suites.

  5. app/components/Views/Settings/AppInformation/index.test.tsx: Unit tests for the new feature flags display. No E2E impact.

No E2E tags are warranted because:

  • No changes to core flows (transactions, swaps, accounts, networks, onboarding)
  • No changes to shared components (TabBar, navigation, modals, confirmations)
  • No changes to controllers or Engine
  • The AppInformation change is a debug-only UI addition in a deeply nested settings screen
  • All changes are well-covered by the accompanying unit tests

Performance Test Selection:
No performance impact expected. The AppInformation settings screen change is a simple UI addition (feature flags list) hidden behind a long-press gesture. Version bumps and CI changes have no performance implications. No changes to rendering-intensive components, data loading, state management, or critical user flows.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No QA Needed Apply this label when your PR does not need any QA effort. risk-low Low testing needed · Low bug introduction risk size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants