Skip to content

fix: remove animation config from learn more import srp pop up#28629

Merged
vinnyhoward merged 5 commits intomainfrom
fix-mcwp-510-learn-more-srp-buggy-transition
Apr 10, 2026
Merged

fix: remove animation config from learn more import srp pop up#28629
vinnyhoward merged 5 commits intomainfrom
fix-mcwp-510-learn-more-srp-buggy-transition

Conversation

@vinnyhoward
Copy link
Copy Markdown
Contributor

@vinnyhoward vinnyhoward commented Apr 9, 2026

Description

Removed react native navigation animation config from learn more import srp pop up

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-510

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

~

Before

before.MP4

After

after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small React Navigation configuration change limited to the Import SRP flow; primary risk is minor UI/transition regressions for the affected modal screens.

Overview
Updates the ImportSRPView stack navigation configuration to use presentation: 'transparentModal' at the navigator level, and removes the per-screen presentation: 'modal' override from Routes.SHEET.SEEDPHRASE_MODAL. This is intended to eliminate the unwanted animation/transition behavior when opening the “learn more / import SRP” popup while keeping the transparent overlay styling.

Reviewed by Cursor Bugbot for commit fa3ddc4. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Apr 9, 2026
@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 9, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.13%. Comparing base (0c26cf4) to head (11574c2).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28629      +/-   ##
==========================================
- Coverage   82.13%   82.13%   -0.01%     
==========================================
  Files        4942     4942              
  Lines      129947   129962      +15     
  Branches    28977    28980       +3     
==========================================
+ Hits       106732   106744      +12     
- Misses      15917    15921       +4     
+ Partials     7298     7297       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
@github-actions github-actions bot added risk-high Extensive testing required · High bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@vinnyhoward vinnyhoward enabled auto-merge April 10, 2026 15:04
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ E2E Fixture Validation — Structural changes detected

Category Count
New keys 0
Missing keys 30
Type mismatches 0
Value mismatches 14 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

@vinnyhoward vinnyhoward added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 59dacd6 Apr 10, 2026
112 of 113 checks passed
@vinnyhoward vinnyhoward deleted the fix-mcwp-510-learn-more-srp-buggy-transition branch April 10, 2026 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-high Extensive testing required · High bug introduction risk size-XS team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants