chore: remove tokensChainsCache usage from usePerpsPaymentTokens

[juanmigdr]

Description

Removes the dependency on selectTokenList (backed by tokensChainsCache) and selectIsIpfsGatewayEnabled from the usePerpsPaymentTokens hook, as part of the broader effort to eliminate tokensChainsCache usage across the codebase.

The tokenList selector was used in two places inside the hook, both of which were effectively dead code:

1. Hyperliquid USDC entry — enhanceTokenWithIcon was called with the current EVM chain's token list to look up the USDC icon. This lookup would virtually never succeed because Hyperliquid tokens don't appear in EVM chain token lists. The symbol-based cross-chain fallback might occasionally match, but USDC_TOKEN_ICON_URL (already exported from @metamask/perps-controller and used elsewhere in the codebase for this exact purpose) is the correct, always-available icon. Replaced with the hardcoded constant.
2. Other wallet tokens — enhanceTokenWithIcon was guarded by tokenList && !token.image. However, useTokensWithBalance already populates token.image via getTokenIconUrl (constructing the MetaMask static CDN URL from the CAIP-19 asset ID) for every token it returns. The !token.image condition was therefore almost never true, making the entire enhancement block a no-op. Removed; tokens now pass through as-is from useTokensWithBalance.

Changelog

CHANGELOG entry: remove tokensChainsCache usage from usePerpsPaymentTokens

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3049

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Moderate risk because it changes how token icons are sourced in the Perps payment token list (now relying on USDC_TOKEN_ICON_URL and useTokensWithBalance images) and removes token-list/IPFS fallbacks, which could affect UI rendering if assumptions are wrong.

Overview
Removes tokensChainsCache-backed dependencies from usePerpsPaymentTokens by dropping selectTokenList/selectIsIpfsGatewayEnabled and the enhanceTokenWithIcon flow.

Hyperliquid USDC now always uses USDC_TOKEN_ICON_URL for its image, and non-Hyperliquid tokens are passed through from useTokensWithBalance with only balance/balanceFiat fallbacks. Associated tests are updated, and tokenIconUtils (and its unit tests) are deleted.

^{Reviewed by Cursor Bugbot for commit f73a8f0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f58dff2. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are entirely within the Perps feature's payment token handling:

1. tokenIconUtils.ts deleted: The enhanceTokenWithIcon utility was removed. Grep confirms it had zero other consumers in the codebase, so no cascade effects.

2. usePerpsPaymentTokens.ts simplified: Removed dynamic icon resolution via token list lookup (which required selectTokenList and selectIsIpfsGatewayEnabled selectors). The Hyperliquid USDC token now uses a static USDC_TOKEN_ICON_URL constant from @metamask/perps-controller. Other tokens pass through their image from useTokensWithBalance unchanged.

3. Test files updated: Both test files updated/deleted to match the simplified implementation.

Tag selection rationale:

• SmokePerps: Primary tag — changes directly affect the Perps payment token hook used in the Add Funds flow
• SmokeWalletPlatform: Required by SmokePerps description (Perps is a section inside Trending tab)
• SmokeConfirmations: Required by SmokePerps description (Add Funds deposits are on-chain transactions)

The risk is low because: (1) the change is a simplification (static URL vs dynamic lookup), (2) USDC is the primary token used in Perps and its icon URL is now hardcoded from the controller package, (3) no shared infrastructure or cross-feature components are affected.

Performance Test Selection:
The changes remove a dynamic token icon resolution utility and replace it with a static URL constant. This is a simplification that reduces computation (no more token list iteration for icon lookup). No UI rendering components, list components, account selectors, or performance-critical paths were modified. No performance tests are warranted.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details