chore(runway): cherry-pick fix: fallback media doesn't take up space cp-7.73.0#28674
Merged
chloeYue merged 1 commit intorelease/7.73.0from Apr 10, 2026
Merged
Conversation
…cp-7.73.0 (#28618) ## **Description** NFT fallback media doesn't take up space in parent container ## **Changelog** CHANGELOG entry:null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-506 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** `~` ### **Before** https://github.com/user-attachments/assets/29a57084-127c-46bf-822e-898438503b31 ### **After** https://github.com/user-attachments/assets/94faeb11-27f1-4142-a920-2d0db6435ebe ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI-only styling change that adjusts `BadgeWrapper` layout behavior for `RemoteImage`/NFT media; main risk is minor visual regressions in badge positioning/sizing across screens using this wrapper. > > **Overview** > Fixes NFT media layout by applying a new `RemoteImageBadgeWrapper` style (`alignSelf: 'auto'`) to the underlying `BadgeWrapper`, allowing the wrapped image/fallback to size within its parent instead of being constrained. > > Updates the `NftDetails` snapshot to reflect the new `alignSelf` value on the badge wrapper container. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 8a8bf58. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
github-actions
bot
added
size-S
risk-low
chloeYue
added
the
skip-smart-e2e-selection
github-actions
bot
added
risk-high
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
Contributor
|
✅ E2E Fixture Validation — Schema is up to date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NFT fallback media doesn't take up space in parent container
Changelog
CHANGELOG entry:null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-506
Manual testing steps
Screenshots/Recordings
~Before
Simulator.Screen.Recording.-.iPhone.17.-.2026-04-09.at.12.21.28.mov
After
Simulator.Screen.Recording.-.iPhone.17.-.2026-04-09.at.12.47.55.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk UI-only styling change that adjusts
BadgeWrapperlayoutbehavior for
RemoteImage/NFT media; main risk is minor visualregressions in badge positioning/sizing across screens using this
wrapper.
Overview
Fixes NFT media layout by applying a new
RemoteImageBadgeWrapperstyle (
alignSelf: 'auto') to the underlyingBadgeWrapper, allowingthe wrapped image/fallback to size within its parent instead of being
constrained.
Updates the
NftDetailssnapshot to reflect the newalignSelfvalueon the badge wrapper container.
Reviewed by Cursor Bugbot for commit
8a8bf58. Bugbot is set up for automated
code reviews on this repo. Configure
here.