test: remove toMatchSnapshot and removed snapshot files in card tests

[cortisiko]

Description

Removes snapshot-based assertions from several Card UI tests (CardAuthentication, CardHome, AddFundsBottomSheet) and replaces them with explicit checks for key text/test IDs.

Cleans up tests to use toBeOnTheScreen() for presence/absence assertions (replacing toBeNull()/truthy checks) and deletes the now-unused Jest snapshot files.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Low risk because changes are limited to test expectations and snapshot cleanup, with no production code modifications.

Overview
Removes toMatchSnapshot() assertions from several Card UI tests (CardAuthentication, CardHome, AddFundsBottomSheet) and deletes the now-unused __snapshots__ files.

Updates assertions to be more explicit and stable by checking for key text/test IDs with toBeOnTheScreen() (including absence checks replacing toBeNull()/truthy expectations).

^{Reviewed by Cursor Bugbot for commit 13353b6. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 96786ee. Configure here.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.89%. Comparing base (9f195d0) to head (96786ee).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #28675       +/-   ##
===========================================
- Coverage   82.14%   57.89%   -24.26%     
===========================================
  Files        4949     4949               
  Lines      130070   130063        -7     
  Branches    29004    29003        -1     
===========================================
- Hits       106851    75304    -31547     
- Misses      15923    48660    +32737     
+ Partials     7296     6099     -1197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 98%

click to see 🤖 AI reasoning details

E2E Test Selection:
All 31 changed files are exclusively unit test files (.test.tsx) and their associated snapshot files (snapshots/.snap) within the app/components/UI/Card/ directory. No production application code was modified.

The changes are purely test quality improvements:

1. Replacing snapshot-based assertions (toMatchSnapshot(), toJSON()) with explicit behavioral assertions using toBeOnTheScreen()
2. Replacing toBeNull() with not.toBeOnTheScreen() for better testing semantics
3. Removing obsolete snapshot files that are no longer needed
4. Renaming test descriptions to remove "matches snapshot" wording

Since no production code, E2E test infrastructure, controllers, navigation, shared components, or app logic was changed, there is no need to run any E2E test tags. These unit test refactoring changes cannot affect E2E test outcomes.

Performance Test Selection:
All changes are confined to unit test files only. No production code, UI components, state management, or app logic was modified. There is no performance impact from these test refactoring changes.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud